[coreboot-gerrit] New patch to review for coreboot: a005be7 x86/smm/smihandler.c: break case in switch
Patrick Georgi (patrick@georgi-clan.de)
gerrit at coreboot.org
Sat Aug 9 20:53:27 CEST 2014
Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6571
-gerrit
commit a005be7e571ee7fac731cd56c9e5c832236ec076
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Sat Aug 9 20:52:21 2014 +0200
x86/smm/smihandler.c: break case in switch
The case doesn't look like a deliberate fall-through,
since the next case (SNB/IVB/HSW) is more specific
than the one before it, so break out.
Change-Id: I55497aefe9e835842a82121270f2b2a9952f560d
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
src/cpu/x86/smm/smihandler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/x86/smm/smihandler.c b/src/cpu/x86/smm/smihandler.c
index fc30909..c864df2 100644
--- a/src/cpu/x86/smm/smihandler.c
+++ b/src/cpu/x86/smm/smihandler.c
@@ -163,6 +163,7 @@ void smi_handler(u32 smm_revision)
state_save.type = EM64T;
state_save.em64t_state_save =
smm_save_state(smm_base, 0x7d00, node);
+ break;
case 0x00030101: /* SandyBridge, IvyBridge, and Haswell */
state_save.type = EM64T101;
state_save.em64t101_state_save =
More information about the coreboot-gerrit
mailing list