[coreboot-gerrit] Patch merged into coreboot/master: b6239b8 romcc: properly check out-of-range unsigned longs

gerrit at coreboot.org gerrit at coreboot.org
Sun Aug 10 08:19:45 CEST 2014


the following patch was just integrated into master:
commit b6239b81aa3a3ac9cb08aa70d1f1179e1619f429
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Aug 9 19:42:08 2014 +0200

    romcc: properly check out-of-range unsigned longs
    
    Testing if an unsigned long is greater than ULONG_T_MAX isn't very
    useful. The second half of the test checked for too small values
    (ie. <= -ULONG_T_MAX).
    
    In both cases errno is set to ERANGE, so just check for that.
    
    Change-Id: I92bad9d1715673531bef5d5d5756feddeb7674b4
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-on: http://review.coreboot.org/6568
    Tested-by: build bot (Jenkins)
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/6568 for details.

-gerrit



More information about the coreboot-gerrit mailing list