[coreboot-gerrit] New patch to review for coreboot: c5d373a pit: snow: Fix snow, fix up pit write protect.

[Isaac Christensen (isaac.christensen@se-eng.com)]

Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6635

-gerrit

commit c5d373a2822a49d8a88feef1fa841943db6063e6
Author: Gabe Black <gabeblack at google.com>
Date:   Thu Sep 12 06:23:51 2013 -0700

    pit: snow: Fix snow, fix up pit write protect.
    
    A recent change to support early firmware selection on ARM broke snow and was
    incompletely implemented on pit. This change fixes snow by applying
    the remaining part of the change that had been applied to pit,
    and also hooks up real values in the get_write_protect_state function.
    
    Change-Id: Ifef7ad1bf399f79353daec3dd46973f2b2022e37
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/169120
    Reviewed-by: David Hendrix <dhendrix at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 841773e048cd9cfbb64782059c24e29c467f17c8)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/mainboard/google/pit/chromeos.c  | 2 +-
 src/mainboard/google/snow/chromeos.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/pit/chromeos.c b/src/mainboard/google/pit/chromeos.c
index c2db165..2933a35 100644
--- a/src/mainboard/google/pit/chromeos.c
+++ b/src/mainboard/google/pit/chromeos.c
@@ -97,5 +97,5 @@ int get_recovery_mode_switch(void)
 
 int get_write_protect_state(void)
 {
-	return 0; // FIXME what GPIO? // WP hard coded to disabled
+	return !gpio_get_value(GPIO_X30);
 }
diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index de882ab..5310a4d 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -95,7 +95,7 @@ int get_recovery_mode_switch(void)
 		  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
 }
 
-int get_recovery_mode_from_vbnv(void)
+int get_write_protect_state(void)
 {
-	return 0;
+	return !gpio_get_value(GPIO_D16);
 }