[coreboot-gerrit] New patch to review for coreboot: 8dc136a libpayload: Add in a missing "static".

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Wed Aug 13 20:37:17 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6648

-gerrit

commit 8dc136a6facf546c0e7c3ea0a4ed09369ef55ddd
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Sep 18 05:37:20 2013 -0700

    libpayload: Add in a missing "static".
    
    The readwrite_chunk was private to the usb mass storage driver, but wasn't
    marked as static which was upsetting the compiler.
    
    Change-Id: I0ef5c5f96a29f793dd43ff672a939902bad13c45
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/169816
    Reviewed-by: Julius Werner <jwerner at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 8140e6145b3d072b7f12a924418570022207c065)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 payloads/libpayload/drivers/usb/usbmsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c
index 1f8c551..464d73d 100644
--- a/payloads/libpayload/drivers/usb/usbmsc.c
+++ b/payloads/libpayload/drivers/usb/usbmsc.c
@@ -365,7 +365,7 @@ readwrite_blocks_512 (usbdev_t *dev, int start, int n,
  * @param buf buffer to read into or write from. Must be at least n*sectorsize bytes
  * @return 0 on success, 1 on failure
  */
-int
+static int
 readwrite_chunk (usbdev_t *dev, int start, int n, cbw_direction dir, u8 *buf)
 {
 	cmdblock_t cb;



More information about the coreboot-gerrit mailing list