[coreboot-gerrit] Patch merged into coreboot/master: fa938c7 exynos5: Refactor crazy old U-Boot base address macros away
gerrit at coreboot.org
gerrit at coreboot.org
Thu Aug 14 01:43:13 CEST 2014
the following patch was just integrated into master:
commit fa938c7508627c0dfcf03960957ef8631fc53f02
Author: Julius Werner <jwerner at chromium.org>
Date: Thu Aug 29 14:17:36 2013 -0700
exynos5: Refactor crazy old U-Boot base address macros away
All this samsung_get_base_address_of_device_with_a_really_long_name()
boilerplate makes my eyes bleed... I think there are so much cleaner
ways to do this. Unfortunately changing this ends up touching nearly
every Exynos5 file, but I hope you agree that it's worth it (and the
sooner we get it over with, the better... I can't bring myself to make
another device fit into that ugly scheme).
This also removes the redundant EXYNOS5 base address definitions from
the 5420 directory when there are EXYNOS5420 ones, to avoid complete
confusion. The new scheme tries to use EXYNOS5 for base addresses and
exynos5 for types that are common between the two processors, and
EXYNOS5420/exynos5420 for things that have changes (although I probably
didn't catch all differences).
Change-Id: I87e58434490ed55a9bbe743af1f9bf2520dec13f
Signed-off-by: Julius Werner <jwerner at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/167579
Reviewed-by: Stefan Reinauer <reinauer at google.com>
Reviewed-by: David Hendricks <dhendrix at chromium.org>
Reviewed-by: ron minnich <rminnich at chromium.org>
(cherry picked from commit 66c87693352c248eec029c1ce83fb295059e6b5b)
Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
Reviewed-on: http://review.coreboot.org/6632
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
See http://review.coreboot.org/6632 for details.
-gerrit
More information about the coreboot-gerrit
mailing list