[coreboot-gerrit] Patch set updated for coreboot: 70456d1 lenovo/t530: Be safe by disabling blink gpio hw with a writeout

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sat Aug 23 06:28:51 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6436

-gerrit

commit 70456d153053514484d338448c80854daa284734
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Aug 1 20:30:21 2014 +1000

    lenovo/t530: Be safe by disabling blink gpio hw with a writeout
    
    This disables the blink hardware as it seems to be in the dump. This is
    safer as it does not rely on 0 as the reset value when '0x00040000' is
    the default according to the util/inteltool. As seen:
    
    gpiobase+0x0018: 0x00040000 (GPO_BLINK) DIFF
    
    Change-Id: Ia1fde108bf3752484f5e991600c435f776af0ced
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/lenovo/t530/romstage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c
index 9aa8c4f..a7d83cc 100644
--- a/src/mainboard/lenovo/t530/romstage.c
+++ b/src/mainboard/lenovo/t530/romstage.c
@@ -187,6 +187,7 @@ void main(unsigned long bist)
 	outl(0x3962a5ff, DEFAULT_GPIOBASE + GPIO_USE_SEL);
 	outl(0x8ebf6aff, DEFAULT_GPIOBASE + GP_IO_SEL);
 	outl(0x66917ebb, DEFAULT_GPIOBASE + GP_LVL);
+	outl(0x00000000, DEFAULT_GPIOBASE + GPO_BLINK);
 	outl(0x00002002, DEFAULT_GPIOBASE + GPI_INV);
 	outl(0x02ff08fe, DEFAULT_GPIOBASE + GPIO_USE_SEL2);
 	outl(0x1f47f7fd, DEFAULT_GPIOBASE + GP_IO_SEL2);



More information about the coreboot-gerrit mailing list