[coreboot-gerrit] Patch set updated for coreboot: c665023 TEST clang warn as error

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Dec 7 17:48:30 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672

-gerrit

commit c665023bcf63033940b4c26e76be6e090da61de5
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Dec 7 02:46:07 2014 +1100

    TEST clang warn as error
    
    Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 Makefile    | 2 +-
 src/Kconfig | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index eaba3e4..5a7e687 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
 # FIXME: armv7/aarch64 won't build right now
 # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a
 # this means the triple is i386-linux-elf instead of i386-none-elf
-CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32
+CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function
 CC_x86_32:=clang
 HOSTCC := clang
 
diff --git a/src/Kconfig b/src/Kconfig
index 533bc5c..7f033a2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID
 # the whole treee.
 config WARNINGS_ARE_ERRORS
 	bool
-	default y if !COMPILER_LLVM_CLANG
-	default n if COMPILER_LLVM_CLANG
+	default y
 
 # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
 # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are



More information about the coreboot-gerrit mailing list