[coreboot-gerrit] Patch set updated for coreboot: 2021aa7 drivers/intel/fsp/fsp_util.c: Remove attribute, optimize("O0")

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Mon Dec 8 18:02:36 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7694

-gerrit

commit 2021aa7ca7fc06c14aec5803a3a2a886736713a9
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Dec 8 03:47:20 2014 +1100

    drivers/intel/fsp/fsp_util.c: Remove attribute,optimize("O0")
    
    This is not actually required. Tested on 'minnow max' hardware as
    well as compared the asm of the optimized and non-optimized. Thanks Martin!
    
    Change-Id: I06e71876c3a3a15101013623797c2ebbf449756d
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Found-by: Clang
---
 src/drivers/intel/fsp/fsp_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/intel/fsp/fsp_util.c b/src/drivers/intel/fsp/fsp_util.c
index e15c82e..3e3f727 100644
--- a/src/drivers/intel/fsp/fsp_util.c
+++ b/src/drivers/intel/fsp/fsp_util.c
@@ -103,7 +103,7 @@ void __attribute__ ((noreturn)) fsp_early_init (FSP_INFO_HEADER *fsp_ptr)
 }
 #endif	/* __PRE_RAM__ */
 
-volatile u8 * __attribute__((optimize("O0"))) find_fsp ()
+volatile u8 * find_fsp ()
 {
 
 #ifdef __PRE_RAM__



More information about the coreboot-gerrit mailing list