[coreboot-gerrit] Patch set updated for coreboot: 996cb4e vendorcode/amd/pi/00730F01/Lib/amdlib.c: Remove optimize attribute
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Tue Dec 9 09:05:50 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7689
-gerrit
commit 996cb4eaf183b60507487ffd8b025dac932bec31
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Mon Dec 8 02:17:12 2014 +1100
vendorcode/amd/pi/00730F01/Lib/amdlib.c: Remove optimize attribute
Remove '__attribute__((optimize("Os")))' as it is unlikely to be
necessary as it is not used in other families that have the same
code and only hides deeper issues.
Change-Id: Ica890812ebc2fb659b9c3e46b40cf3f6534b3cf2
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/vendorcode/amd/pi/00730F01/Lib/amdlib.c | 31 -----------------------------
1 file changed, 31 deletions(-)
diff --git a/src/vendorcode/amd/pi/00730F01/Lib/amdlib.c b/src/vendorcode/amd/pi/00730F01/Lib/amdlib.c
index f2e6b91..fa4fa0b 100644
--- a/src/vendorcode/amd/pi/00730F01/Lib/amdlib.c
+++ b/src/vendorcode/amd/pi/00730F01/Lib/amdlib.c
@@ -89,7 +89,6 @@ ReadNumberOfCpuCores(
void
);
-__attribute__((optimize("Os")))
UINT8
ReadIo8 (
IN UINT16 Address
@@ -98,7 +97,6 @@ ReadIo8 (
return __inbyte (Address);
}
-__attribute__((optimize("Os")))
UINT16
ReadIo16 (
IN UINT16 Address
@@ -107,7 +105,6 @@ ReadIo16 (
return __inword (Address);
}
-__attribute__((optimize("Os")))
UINT32
ReadIo32 (
IN UINT16 Address
@@ -116,7 +113,6 @@ ReadIo32 (
return __indword (Address);
}
-__attribute__((optimize("Os")))
VOID
WriteIo8 (
IN UINT16 Address,
@@ -126,7 +122,6 @@ WriteIo8 (
__outbyte (Address, Data);
}
-__attribute__((optimize("Os")))
VOID
WriteIo16 (
IN UINT16 Address,
@@ -136,7 +131,6 @@ WriteIo16 (
__outword (Address, Data);
}
-__attribute__((optimize("Os")))
VOID
WriteIo32 (
IN UINT16 Address,
@@ -146,7 +140,6 @@ WriteIo32 (
__outdword (Address, Data);
}
-__attribute__((optimize("Os")))
STATIC
UINT64 SetFsBase (
UINT64 address
@@ -159,7 +152,6 @@ UINT64 SetFsBase (
return hwcr;
}
-__attribute__((optimize("Os")))
STATIC
VOID
RestoreHwcr (
@@ -170,7 +162,6 @@ RestoreHwcr (
__writemsr (0xC0010015, value);
}
-__attribute__((optimize("Os")))
UINT8
Read64Mem8 (
IN UINT64 Address
@@ -187,7 +178,6 @@ Read64Mem8 (
return dataRead;
}
-__attribute__((optimize("Os")))
UINT16
Read64Mem16 (
IN UINT64 Address
@@ -204,7 +194,6 @@ Read64Mem16 (
return dataRead;
}
-__attribute__((optimize("Os")))
UINT32
Read64Mem32 (
IN UINT64 Address
@@ -221,7 +210,6 @@ Read64Mem32 (
return dataRead;
}
-__attribute__((optimize("Os")))
VOID
Write64Mem8 (
IN UINT64 Address,
@@ -239,7 +227,6 @@ Write64Mem8 (
}
}
-__attribute__((optimize("Os")))
VOID
Write64Mem16 (
IN UINT64 Address,
@@ -257,7 +244,6 @@ Write64Mem16 (
}
}
-__attribute__((optimize("Os")))
VOID
Write64Mem32 (
IN UINT64 Address,
@@ -275,7 +261,6 @@ Write64Mem32 (
}
}
-__attribute__((optimize("Os")))
VOID
LibAmdReadCpuReg (
IN UINT8 RegNum,
@@ -308,7 +293,6 @@ LibAmdReadCpuReg (
}
}
-__attribute__((optimize("Os")))
VOID
LibAmdWriteCpuReg (
IN UINT8 RegNum,
@@ -339,7 +323,6 @@ LibAmdWriteCpuReg (
}
}
-__attribute__((optimize("Os")))
VOID
LibAmdWriteBackInvalidateCache (
void
@@ -348,7 +331,6 @@ LibAmdWriteBackInvalidateCache (
__wbinvd ();
}
-__attribute__((optimize("Os")))
VOID
LibAmdHDTBreakPoint (
void
@@ -358,7 +340,6 @@ LibAmdHDTBreakPoint (
__debugbreak (); // do you really need icebp? If so, go back to asm code
}
-__attribute__((optimize("Os")))
UINT8
LibAmdBitScanForward (
IN UINT32 value
@@ -371,7 +352,6 @@ LibAmdBitScanForward (
return (UINT8) Index;
}
-__attribute__((optimize("Os")))
UINT8
LibAmdBitScanReverse (
IN UINT32 value
@@ -384,7 +364,6 @@ LibAmdBitScanReverse (
return (UINT8) Index;
}
-__attribute__((optimize("Os")))
VOID
LibAmdMsrRead (
IN UINT32 MsrAddress,
@@ -398,7 +377,6 @@ LibAmdMsrRead (
*Value = __readmsr (MsrAddress);
}
-__attribute__((optimize("Os")))
VOID
LibAmdMsrWrite (
IN UINT32 MsrAddress,
@@ -409,7 +387,6 @@ LibAmdMsrWrite (
__writemsr (MsrAddress, *Value);
}
-__attribute__((optimize("Os")))
void LibAmdCpuidRead (
IN UINT32 CpuidFcnAddress,
OUT CPUID_DATA* Value,
@@ -419,7 +396,6 @@ void LibAmdCpuidRead (
__cpuid ((int *)Value, CpuidFcnAddress);
}
-__attribute__((optimize("Os")))
UINT64
ReadTSC (
void
@@ -428,7 +404,6 @@ ReadTSC (
return __rdtsc ();
}
-__attribute__((optimize("Os")))
VOID
LibAmdSimNowEnterDebugger (
void
@@ -444,7 +419,6 @@ LibAmdSimNowEnterDebugger (
((VOID (*)(VOID)) (size_t) opcode) (); // call the function
}
-__attribute__((optimize("Os")))
VOID
IdsOutPort (
IN UINT32 Addr,
@@ -455,7 +429,6 @@ IdsOutPort (
__outdword ((UINT16) Addr, Value);
}
-__attribute__((optimize("Os")))
VOID
StopHere (
void
@@ -465,7 +438,6 @@ StopHere (
while (x);
}
-__attribute__((optimize("Os")))
VOID
LibAmdCLFlush (
IN UINT64 Address,
@@ -485,7 +457,6 @@ LibAmdCLFlush (
}
-__attribute__((optimize("Os")))
VOID
LibAmdFinit(
void
@@ -1367,7 +1338,6 @@ LibAmdAccessWidth (
return Width;
}
-__attribute__((optimize("Os")))
VOID
CpuidRead (
IN UINT32 CpuidFcnAddress,
@@ -1377,7 +1347,6 @@ CpuidRead (
__cpuid ((int *)Value, CpuidFcnAddress);
}
-__attribute__((optimize("Os")))
UINT8
ReadNumberOfCpuCores(
void
More information about the coreboot-gerrit
mailing list