[coreboot-gerrit] Patch merged into coreboot/master: 967058f spi: Factor EC protocol details out of the SPI drivers.

gerrit at coreboot.org gerrit at coreboot.org
Tue Dec 9 20:32:08 CET 2014


the following patch was just integrated into master:
commit 967058f807418dc964ca04849b59c3b2a03dbee5
Author: Gabe Black <gabeblack at google.com>
Date:   Fri Mar 21 21:32:12 2014 -0700

    spi: Factor EC protocol details out of the SPI drivers.
    
    The SPI drivers for tegra and exynos5420 have code in them which waits for a
    frame header and leaves filler data out. The SPI driver shouldn't have support
    for frame headers directly. If a device uses them, it should support them
    itself. That makes the SPI drivers simpler and easier to write.
    
    When moving the frame handling logic into the EC support code, EC communication
    continued to work on tegra but no longer worked on exynos5420. That suggested
    the SPI driver on the 5420 wasn't working correctly, so I replaced that with
    the implementation in depthcharge. Unfortunately that implementation doesn't
    support waiting for a frame header for the EC, so these changes are combined
    into one.
    
    BUG=None
    TEST=Built and booted on pit. Built and booted on nyan. In both cases,
    verified that there were no error messages from the SPI drivers or the EC
    code.
    BRANCH=None
    
    Original-Change-Id: I62a68820c632f154acece94f54276ddcd1442c09
    Original-Signed-off-by: Gabe Black <gabeblack at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/191192
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    Original-Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Original-Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 4fcfed280ad70f14a013d5353aa0bee0af540630)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Id8824523abc7afcbc214845901628833e135d142
    Reviewed-on: http://review.coreboot.org/7706
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <gaumless at gmail.com>


See http://review.coreboot.org/7706 for details.

-gerrit



More information about the coreboot-gerrit mailing list