[coreboot-gerrit] New patch to review for coreboot: 4b64b98 southbridge/sis: Spelling/comment fixes

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Tue Dec 9 21:52:45 CET 2014


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7733

-gerrit

commit 4b64b980b4e8e642d48ea2092d158fb2cfa144bb
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Tue Dec 9 13:51:49 2014 -0700

    southbridge/sis: Spelling/comment fixes
    
    Change-Id: I6a0f5406fb3bc3e8aa3a1111b1d702f530c9329b
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/southbridge/sis/sis966/lpc.c    | 6 +++---
 src/southbridge/sis/sis966/sis761.c | 8 ++++----
 src/southbridge/sis/sis966/sis966.c | 7 ++++++-
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/southbridge/sis/sis966/lpc.c b/src/southbridge/sis/sis966/lpc.c
index 0e11c6f..a61883b 100644
--- a/src/southbridge/sis/sis966/lpc.c
+++ b/src/southbridge/sis/sis966/lpc.c
@@ -185,7 +185,7 @@ static void sis966_lpc_read_resources(device_t dev)
 /**
  * Enable resources for children devices.
  *
- * @param dev The device whos children's resources are to be enabled.
+ * @param dev The device whose children's resources are to be enabled.
  */
 static void sis966_lpc_enable_childrens_resources(device_t dev)
 {
@@ -212,11 +212,11 @@ static void sis966_lpc_enable_childrens_resources(device_t dev)
 						reg |= (1<<0);	break;
 					case 0x2f8: // COM2
 						reg |= (1<<1);  break;
-					case 0x378: // Parallal 1
+					case 0x378: // Parallel 1
 						reg |= (1<<24); break;
 					case 0x3f0: // FD0
 						reg |= (1<<20); break;
-					case 0x220:  // Aduio 0
+					case 0x220:  // Audio 0
 						reg |= (1<<8);	break;
 					case 0x300:  // Midi 0
 						reg |= (1<<12);	break;
diff --git a/src/southbridge/sis/sis966/sis761.c b/src/southbridge/sis/sis966/sis761.c
index 79a64f9..c92b666 100644
--- a/src/southbridge/sis/sis966/sis761.c
+++ b/src/southbridge/sis/sis966/sis761.c
@@ -22,7 +22,7 @@
 /*
  * Turn off machine check triggers when reading
  * pci space where there are no devices.
- * This is necessary when scaning the bus for
+ * This is necessary when scanning the bus for
  * devices which is done by the kernel
  *
  * written in 2003 by Eric Biederman
@@ -57,13 +57,13 @@ static inline msr_t rdmsr(unsigned index)
 /**
  * Read resources for AGP aperture.
  *
- * There is only one AGP aperture resource needed. The resoruce is added to
+ * There is only one AGP aperture resource needed. The resource is added to
  * the northbridge of BSP.
  *
  * The same trick can be used to augment legacy VGA resources which can
  * be detect by generic PCI resource allocator for VGA devices.
  * BAD: it is more tricky than I think, the resource allocation code is
- * implemented in a way to NOT DOING legacy VGA resource allcation on
+ * implemented in a way to NOT DOING legacy VGA resource allocation on
  * purpose :-(.
  *
  * @param dev TODO
@@ -74,7 +74,7 @@ static void sis761_read_resources(device_t dev)
 	printk(BIOS_DEBUG, "sis761_read_resources ------->\n");
 	pci_dev_read_resources(dev);
 
-	/* If we are not the first processor don't allocate the gart apeture */
+	/* If we are not the first processor don't allocate the gart aperture */
 	if (dev->path.pci.devfn != PCI_DEVFN(0x0, 0)) {
 		printk(BIOS_DEBUG, "sis761_not_the_first_processor !!!\n");
 		return;
diff --git a/src/southbridge/sis/sis966/sis966.c b/src/southbridge/sis/sis966/sis966.c
index 68da917..5fecd3c 100644
--- a/src/southbridge/sis/sis966/sis966.c
+++ b/src/southbridge/sis/sis966/sis966.c
@@ -180,7 +180,12 @@ void sis966_enable(device_t dev)
 
 	if (!dev->enabled) {
 		final_reg |= (1 << index);// disable it
-		//The reason for using final_reg, if diable func 1, the func 2 will be func 1 so We need disable them one time.
+		/*
+		 * The reason for using final_reg is that if func 1 is disabled,
+		 * then func 2 will become func 1.
+		 * Because of this, we need loop through disabling them all at
+		 * the same time.
+		 */
 	}
 
 	if(index == 9 ) { //NIC1 is the final, We need update final reg to 0xe8



More information about the coreboot-gerrit mailing list