[coreboot-gerrit] New patch to review for coreboot: 8d6edd3 tegra124: set MOT bit for I2C-over-AUX

[Marc Jones (marc.jones@se-eng.com)]

Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7763

-gerrit

commit 8d6edd329a97338d712b5f73a9b0897b8457846e
Author: Ken Chang <kenc at nvidia.com>
Date:   Tue Apr 15 17:00:17 2014 +0800

    tegra124: set MOT bit for I2C-over-AUX
    
    According to DP version 1.2a, The MOT (Middle-of-Transaction) bit
    must be set when the I2C transaction does not stop with the current
    AUX transaction.
    Thus the correct steps for an I2C read shall be:
    1. I2C command write with MOT set to 1
    2. I2C command read to the same address with MOT set to 0
    
    BUG=chrome-os-partner:27679
    TEST=EDID data read from LP140WH8 panel is correct while it's a
    repeated pattern of the first 16 bytes without this CL
    BRANCH=none
    
    Original-Change-Id: I0526beffb8852fbbe0eb5bb80e370261617a59b8
    Original-Signed-off-by: Ken Chang <kenc at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/194915
    Original-Reviewed-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    (cherry picked from commit 466ab0e00744f79ae3720474140d95e5f0828de9)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ic8ad38b4b08989dd7178d59151e1e276b8a58439
---
 src/soc/nvidia/tegra124/dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra124/dp.c b/src/soc/nvidia/tegra124/dp.c
index e5c0632..f539ec3 100644
--- a/src/soc/nvidia/tegra124/dp.c
+++ b/src/soc/nvidia/tegra124/dp.c
@@ -337,7 +337,7 @@ int tegra_dc_i2c_aux_read(struct tegra_dc_dp_data *dp, u32 i2c_addr,
 
 		u32 len = 1;
 		ret = tegra_dc_dpaux_write_chunk(
-				dp, DPAUX_DP_AUXCTL_CMD_I2CWR, i2c_addr,
+				dp, DPAUX_DP_AUXCTL_CMD_MOTWR, i2c_addr,
 				&addr, &len, aux_stat);
 		if (ret) {
 			printk(BIOS_ERR, "%s: error sending address to read.\n",