[coreboot-gerrit] Patch set updated for coreboot: f17462a tegra124: Always enable DC when attaching SOR.

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Dec 15 23:17:58 CET 2014


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7770

-gerrit

commit f17462ad77dfa45c1a6fe50ee7f62515145b885d
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Fri Apr 18 00:32:41 2014 +0800

    tegra124: Always enable DC when attaching SOR.
    
    We found that without enabling DC in tegra_dc_sor_enable_dc, kernel would have
    problem showing the text console before graphics interface is initialized, for
    example "chromeos factory install shim (text only)" or the "splash screen".
    
    BRANCH=none
    BUG=chrome-os-partner:28082
    TEST=emerge-nyan coreboot chromeos-bootimage
         Boots factory install shim and see text console.
    
    Original-Change-Id: I6fce963ceddd125dd52789d2ec843cc2ee05f1f5
    Original-Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/195388
    (cherry picked from commit 375a86be9b23650cd96e46b07c7a0b5c10970797)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ib75e3ffac9b216c7486845cb8459dd8952d51fe6
---
 src/soc/nvidia/tegra124/sor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c
index d82020a..0e96764 100644
--- a/src/soc/nvidia/tegra124/sor.c
+++ b/src/soc/nvidia/tegra124/sor.c
@@ -659,7 +659,8 @@ static void tegra_dc_sor_enable_dc(struct tegra_dc_sor_data *sor)
 	WRITEL(reg_val | WRITE_MUX_ACTIVE, &disp_ctrl->cmd.state_access);
 	WRITEL(VSYNC_H_POSITION(1), &disp_ctrl->disp.disp_timing_opt);
 
-	/* Enable DC */
+	/* Enable DC now - otherwise pure text console may not show. */
+	WRITEL(DISP_CTRL_MODE_C_DISPLAY, &disp_ctrl->cmd.disp_cmd);
 	WRITEL(reg_val, &disp_ctrl->cmd.state_access);
 }
 



More information about the coreboot-gerrit mailing list