[coreboot-gerrit] Patch set updated for coreboot: 3374a5e baytrail SOCs: Add missing comma in gpio.h

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Wed Dec 17 17:57:02 CET 2014


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7801

-gerrit

commit 3374a5e271d565c8ae20dabcdbc81ea92532422f
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Mon Dec 15 09:46:01 2014 -0700

    baytrail SOCs: Add missing comma in gpio.h
    
    The GPIO_OUT_LOW #define was missing an internal comma in both
    soc/intel/baytrail and soc/intel/fsp_baytrail.
    
    Thanks to Werner Zeh for pointing this out.
    
    Change-Id: I2e5507058739e5fdc2c0e43e0380058458870e46
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/soc/intel/baytrail/baytrail/gpio.h     | 2 +-
 src/soc/intel/fsp_baytrail/baytrail/gpio.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/baytrail/baytrail/gpio.h b/src/soc/intel/baytrail/baytrail/gpio.h
index a431324..09e45a1 100644
--- a/src/soc/intel/baytrail/baytrail/gpio.h
+++ b/src/soc/intel/baytrail/baytrail/gpio.h
@@ -208,7 +208,7 @@
 
 
 #define GPIO_OUT_LOW \
-	{ .pad_conf0 = PAD_PULL_DISABLE | PAD_CONFIG0_DEFAULT \
+	{ .pad_conf0 = PAD_PULL_DISABLE | PAD_CONFIG0_DEFAULT, \
 	  .pad_conf1 = PAD_CONFIG1_DEFAULT, \
 	  .pad_val   = PAD_VAL_OUTPUT | PAD_VAL_LOW, \
 	  .use_sel   = GPIO_USE_LEGACY, \
diff --git a/src/soc/intel/fsp_baytrail/baytrail/gpio.h b/src/soc/intel/fsp_baytrail/baytrail/gpio.h
index e15aeb8..325eeaa 100644
--- a/src/soc/intel/fsp_baytrail/baytrail/gpio.h
+++ b/src/soc/intel/fsp_baytrail/baytrail/gpio.h
@@ -194,7 +194,7 @@
 
 
 #define GPIO_OUT_LOW \
-	{ .pad_conf0 = PAD_PULL_DISABLE | PAD_CONFIG0_DEFAULT \
+	{ .pad_conf0 = PAD_PULL_DISABLE | PAD_CONFIG0_DEFAULT, \
 	  .pad_conf1 = PAD_CONFIG1_DEFAULT, \
 	  .pad_val   = PAD_VAL_OUTPUT | PAD_VAL_LOW, \
 	  .use_sel   = GPIO_USE_LEGACY, \



More information about the coreboot-gerrit mailing list