[coreboot-gerrit] Patch merged into coreboot/master: f2c9837 ifdtool: Add O_BINARY to open flags for Windows compatibility

gerrit at coreboot.org gerrit at coreboot.org
Fri Dec 19 18:55:51 CET 2014


the following patch was just integrated into master:
commit f2c9837e6f30e65f0a53b1c53c328ef8b6bf71f4
Author: Scott Duplichan <scott at notabs.org>
Date:   Fri Dec 12 21:03:06 2014 -0600

    ifdtool: Add O_BINARY to open flags for Windows compatibility
    
    Windows requires O_BINARY when opening a binary file. Otherwise
    \n characters get expanded to \r\n and <ctrl>z is treated as
    end of file. For compatibility with non-Windows hosts, the patch
    defines O_BINARY if it is not already defined.
    
    Change-Id: I04cd609b644b1edbe9104153b43b9996811ffd38
    Signed-off-by: Scott Duplichan <scott at notabs.org>
    Reviewed-on: http://review.coreboot.org/7789
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>


See http://review.coreboot.org/7789 for details.

-gerrit



More information about the coreboot-gerrit mailing list