[coreboot-gerrit] New patch to review for coreboot: dc54c6b soc/samsung/exynos: Sync 'power.c' between chip variants

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Dec 23 13:57:18 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7918

-gerrit

commit dc54c6b76cda99bc306ff07cb69dd58b2d8dfcb6
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Dec 23 23:48:01 2014 +1100

    soc/samsung/exynos: Sync 'power.c' between chip variants
    
    Change-Id: I06d83be840b49ee7523b34e1dba5ec038256b3f4
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/soc/samsung/exynos5250/power.c | 6 ++++--
 src/soc/samsung/exynos5250/power.h | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/soc/samsung/exynos5250/power.c b/src/soc/samsung/exynos5250/power.c
index 27089c6..7d94712 100644
--- a/src/soc/samsung/exynos5250/power.c
+++ b/src/soc/samsung/exynos5250/power.c
@@ -22,7 +22,9 @@
 #include <arch/io.h>
 #include <console/console.h>
 #include <halt.h>
+#include "dmc.h"
 #include "power.h"
+#include "setup.h"
 
 /* Set the PS-Hold drive value */
 static void ps_hold_setup(void)
@@ -51,7 +53,7 @@ void power_shutdown(void)
 
 void power_enable_dp_phy(void)
 {
-	setbits_le32(&exynos_power->dptx_phy_control, DPTX_PHY_ENABLE);
+	setbits_le32(&exynos_power->dptx_phy_control, EXYNOS_DP_PHY_ENABLE);
 }
 
 void power_enable_hw_thermal_trip(void)
@@ -82,7 +84,7 @@ void power_enable_xclkout(void)
 {
 	/* use xxti for xclk out */
 	clrsetbits_le32(&exynos_power->pmu_debug, PMU_DEBUG_CLKOUT_SEL_MASK,
-				PMU_DEBUG_XXTI);
+			PMU_DEBUG_XXTI);
 }
 
 void power_release_uart_retention(void)
diff --git a/src/soc/samsung/exynos5250/power.h b/src/soc/samsung/exynos5250/power.h
index 734bb29..28f25a6 100644
--- a/src/soc/samsung/exynos5250/power.h
+++ b/src/soc/samsung/exynos5250/power.h
@@ -34,7 +34,7 @@ void power_enable_hw_thermal_trip(void);
 #define POWER_PS_HOLD_CONTROL_DATA_HIGH		(1 << 8)
 #define POWER_ENABLE_HW_TRIP			(1UL << 31)
 
-#define DPTX_PHY_ENABLE		(1 << 0)
+#define EXYNOS_DP_PHY_ENABLE	(1 << 0)
 
 /* PMU_DEBUG bits [12:8] = 0x1000 selects XXTI clock source */
 #define PMU_DEBUG_XXTI                          0x1000



More information about the coreboot-gerrit mailing list