[coreboot-gerrit] Patch set updated for coreboot: 78561c9 samsung/exynos*/Makefile.inc: Simplify unnecessary ifeq

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sat Dec 27 03:47:55 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7925

-gerrit

commit 78561c913573538f982aa252e732bc139066ef0a
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Dec 26 12:08:11 2014 +1100

    samsung/exynos*/Makefile.inc: Simplify unnecessary ifeq
    
    It's not needed, as we can use a simpler macro instead.
    
    Change-Id: Ib96f5cfa434d0383ee3bfe49995a8f8830987f20
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/soc/samsung/exynos5250/Makefile.inc | 4 +---
 src/soc/samsung/exynos5420/Makefile.inc | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/soc/samsung/exynos5250/Makefile.inc b/src/soc/samsung/exynos5250/Makefile.inc
index cc89f2d..735ce2e 100644
--- a/src/soc/samsung/exynos5250/Makefile.inc
+++ b/src/soc/samsung/exynos5250/Makefile.inc
@@ -21,9 +21,7 @@ romstage-y += dmc_init_ddr3.c
 romstage-y += power.c
 romstage-y += mct.c
 romstage-y += monotonic_timer.c
-ifeq ($(CONFIG_DRIVERS_UART),y)
-romstage-y += uart.c
-endif
+romstage-$(CONFIG_DRIVERS_UART) += uart.c
 romstage-y += wakeup.c
 romstage-y += gpio.c
 romstage-y += timer.c
diff --git a/src/soc/samsung/exynos5420/Makefile.inc b/src/soc/samsung/exynos5420/Makefile.inc
index 5f37e7e..ac22620 100644
--- a/src/soc/samsung/exynos5420/Makefile.inc
+++ b/src/soc/samsung/exynos5420/Makefile.inc
@@ -22,9 +22,7 @@ romstage-y += dmc_init_ddr3.c
 romstage-y += power.c
 romstage-y += mct.c
 romstage-y += monotonic_timer.c
-ifeq ($(CONFIG_DRIVERS_UART),y)
-romstage-y += uart.c
-endif
+romstage-$(CONFIG_DRIVERS_UART) += uart.c
 romstage-y += wakeup.c
 romstage-y += gpio.c
 romstage-y += timer.c



More information about the coreboot-gerrit mailing list