[coreboot-gerrit] New patch to review for coreboot: 0e0d510 libpayload: don't test for unsigned >= 0
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Dec 29 20:42:01 CET 2014
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7978
-gerrit
commit 0e0d510f583856cdb14588bca99ae4daf5c60c1f
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Mon Dec 29 20:41:37 2014 +0100
libpayload: don't test for unsigned >= 0
Change-Id: Ibeaf6de9505bc6f1e7358a4cfc80228dff7ddb69
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
Found-by: Coverity Scan
---
payloads/libpayload/drivers/video/corebootfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/drivers/video/corebootfb.c b/payloads/libpayload/drivers/video/corebootfb.c
index d661466..34a895a 100644
--- a/payloads/libpayload/drivers/video/corebootfb.c
+++ b/payloads/libpayload/drivers/video/corebootfb.c
@@ -197,7 +197,7 @@ static void corebootfb_update_cursor(void)
paint = CHARS[cursor_y * coreboot_video_console.columns + cursor_x];
}
- if (cursor_y >= 0 && cursor_y < coreboot_video_console.rows)
+ if (cursor_y < coreboot_video_console.rows)
corebootfb_putchar(cursor_y, cursor_x, paint);
}
More information about the coreboot-gerrit
mailing list