[coreboot-gerrit] Patch merged into coreboot/master: b4fbee9 libpayload: video: Make cursor fixup independent of visibility

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit b4fbee9a415296b706c9f4f4dcb3e4d1e3ea3110
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Apr 22 13:06:13 2014 -0700

    libpayload: video: Make cursor fixup independent of visibility
    
    The video console runs a video_console_fixup_cursor() function after
    every printed character to make sure the cursor is still in the output
    window and avoid overflows. For some crazy reason, this function does
    not run when cursor_enabled is false... however, that variable is only
    about cursor *visibility*, and it's imperative that we still do proper
    bounds checking for our output even if the cursor itself doesn't get
    displayed (otherwise we can end up overwriting malloc cookies that cause
    a panic on the next free() and other fun things like that).
    
    In fact, there seems to be no reason at all to even keep track of the
    cursor visibility state in the generic video console framework (the
    specific backends already do it, too), so let's remove that code
    entirely. Also set the default cursor visibilty in the corebootfb
    backend to 0 since that's consistent with what the other backends do.
    
    BUG=None
    TEST=Turn on video console on Big, generate enough output to make it
    scroll, make sure it does not crash.
    
    Original-Change-Id: I1201a5bccb4711b6ecfc4cf47a8ace16331501b4
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/196323
    Original-Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
    (cherry picked from commit 1f880bca06ed0a3f2c75abab399d32a2e51ed10e)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I6c67a9efb00d96fcd67f7bc1ab55a23e78fc479e
    Reviewed-on: http://review.coreboot.org/7908
    Tested-by: build bot (Jenkins)
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>


See http://review.coreboot.org/7908 for details.

-gerrit