[coreboot-gerrit] Patch merged into coreboot/master: b108141 AGESA f15tn: Fix GPP ports resume

gerrit at coreboot.org gerrit at coreboot.org
Sat Feb 1 21:44:35 CET 2014


the following patch was just integrated into master:
commit b108141c09961aa35ccb2a266856a20bb583a447
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Sun Jan 12 00:23:30 2014 +0100

    AGESA f15tn: Fix GPP ports resume
    
    The AGESA resumes the GPP ports in the romstage using FchInitResetGpp(),
    which does FchGppPortInitS3Phase() for S3 resume. The PreInitGppLink()
    looks into CMOS to figure out what ports to just force to Gen1 or
    Gen2 PCIe. Then boot continues and in the ramstage the rest of GPP
    init is executed. There is a problem that nobody sets properly the
    PortDetected flags in the S3 path. As the consequence FchGppDynamicPowerSaving()
    thinks the GPP port is not enabled and shut downs it.
    
    The best fix would be also to remove the CMOS dependency which
    might be some left over, because AGESA does not use CMOS much for
    anything else. There could be also some way how to pass the GPP state
    structure from romstage to ramstage possibly via hudson/resume.c
    but I don't know how to do that. Similar problem is that the "late"
    stage of init again "forgets" the PortDetected state.
    
    This fix fixes the resume issue on Asus F2A85-M. With this patch applied
    both GPP ports (used as PCIe x1 and internal ethernet) are working again
    after resume.
    
    Change-Id: Idaf609043abb09441c6790504d66d23e0637588f
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>


See http://review.coreboot.org/4671 for details.

-gerrit



More information about the coreboot-gerrit mailing list