[coreboot-gerrit] New patch to review for coreboot: 61bd16e7 arch/x86/boot/tables.c: Remove unused variable assignment to `rom_table_end`
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Mon Feb 3 08:41:58 CET 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5106
-gerrit
commit 61bd16e7cabb889380dd0e7a1361e23a473cd996
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Mon Feb 3 08:36:51 2014 +0100
arch/x86/boot/tables.c: Remove unused variable assignment to `rom_table_end`
Building Asus M2V-MX SE with scan-build (3.4) the following warning is
generated.
CC arch/x86/boot/tables.ramstage.o
src/arch/x86/boot/tables.c:240:3: warning: Value stored to 'rom_table_end' is never read
rom_table_end = write_coreboot_table(
^ ~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Change-Id: I098d1238cda16060c3566f242443007cdaf9bd82
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/arch/x86/boot/tables.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/arch/x86/boot/tables.c b/src/arch/x86/boot/tables.c
index e980ed8..23b17f9 100644
--- a/src/arch/x86/boot/tables.c
+++ b/src/arch/x86/boot/tables.c
@@ -237,8 +237,7 @@ struct lb_memory *write_tables(void)
new_high_table_pointer - high_table_pointer);
} else {
/* The coreboot table must be in 0-4K or 960K-1M */
- rom_table_end = write_coreboot_table(
- low_table_start, low_table_end,
+ write_coreboot_table(low_table_start, low_table_end,
rom_table_start, rom_table_end);
}
More information about the coreboot-gerrit
mailing list