[coreboot-gerrit] New patch to review for coreboot: f78bb20 usbdebug: Drop obsolete code

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Feb 5 14:03:04 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5130

-gerrit

commit f78bb20fd010226702caa511f1dede15af44d5d8
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Feb 4 19:18:59 2014 +0200

    usbdebug: Drop obsolete code
    
    Change-Id: I918ca1d0d0d7bcb7e16d41a12830a0357f15b8ed
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/intel/fsp_model_206ax/model_206ax_init.c | 16 ----------------
 src/southbridge/intel/ibexpeak/thermal.c         |  1 -
 2 files changed, 17 deletions(-)

diff --git a/src/cpu/intel/fsp_model_206ax/model_206ax_init.c b/src/cpu/intel/fsp_model_206ax/model_206ax_init.c
index 6eb4787..c362ae3 100644
--- a/src/cpu/intel/fsp_model_206ax/model_206ax_init.c
+++ b/src/cpu/intel/fsp_model_206ax/model_206ax_init.c
@@ -34,7 +34,6 @@
 #include <cpu/x86/cache.h>
 #include <cpu/x86/name.h>
 #include <pc80/mc146818rtc.h>
-#include <usbdebug.h>
 #include "model_206ax.h"
 #include "chip.h"
 
@@ -289,10 +288,6 @@ static void configure_mca(void)
 		wrmsr(IA32_MC0_STATUS + (i * 4), msr);
 }
 
-#if CONFIG_USBDEBUG
-static unsigned ehci_debug_addr;
-#endif
-
 /*
  * Initialize any extra cores/threads in this package.
  */
@@ -365,13 +360,6 @@ static void model_206ax_init(device_t cpu)
 	fill_processor_name(processor_name);
 	printk(BIOS_INFO, "CPU: %s.\n", processor_name);
 
-#if CONFIG_USBDEBUG
-	// Is this caution really needed?
-	if(!ehci_debug_addr)
-		ehci_debug_addr = get_ehci_debug();
-	set_ehci_debug(0);
-#endif
-
 	/* Setup MTRRs based on physical address size */
 	cpuid_regs = cpuid(0x80000008);
 	x86_setup_fixed_mtrrs();
@@ -381,10 +369,6 @@ static void model_206ax_init(device_t cpu)
 	/* Setup Page Attribute Tables (PAT) */
 	// TODO set up PAT
 
-#if CONFIG_USBDEBUG
-	set_ehci_debug(ehci_debug_addr);
-#endif
-
 	/* Enable the local cpu apics */
 	enable_lapic_tpr();
 	setup_lapic();
diff --git a/src/southbridge/intel/ibexpeak/thermal.c b/src/southbridge/intel/ibexpeak/thermal.c
index 11b6555..e01a6db 100644
--- a/src/southbridge/intel/ibexpeak/thermal.c
+++ b/src/southbridge/intel/ibexpeak/thermal.c
@@ -23,7 +23,6 @@
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include "pch.h"
-#include <usbdebug.h>
 #include <arch/io.h>
 
 static void thermal_init(struct device *dev)



More information about the coreboot-gerrit mailing list