[coreboot-gerrit] New patch to review for coreboot: fcb54bf Revert "boardstatus/towiki: Declare southbridge=northbridge=cpu on SOCs"

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sun Feb 9 21:53:58 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5177

-gerrit

commit fcb54bf3f32cbbd020444118c9c8d241f929f652
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Sun Feb 9 14:50:50 2014 -0600

    Revert "boardstatus/towiki: Declare southbridge=northbridge=cpu on SOCs"
    
    This reverts commit b845636ce67f6e7c96bf3fb3008738f596a5d5ce.
    This commit changed the board status script to describe all boards in
    terms of x86 terminology, such as CPU->southbridge->northbridge.
    
    This terminology does not apply to a number of SoCs, in which the
    buses are not connected via successive bridges, and as such it is
    misleading and misguided to describe ideas of southbridge and
    northbridge for these devices.
    
    Change-Id: I98ba24ee00b816bf20d507c6d313ec2946acaedf
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 util/board_status/to-wiki/towiki.sh | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh
index 675b5d5..5d2c6b0 100755
--- a/util/board_status/to-wiki/towiki.sh
+++ b/util/board_status/to-wiki/towiki.sh
@@ -224,8 +224,6 @@ EOF
 		case "$cpu" in
 			ALLWINNER_A10)
 				cpu_nice="Allwinner A10"
-				northbridge_nice="Allwinner A10"
-				southbridge_nice="Allwinner A10"
 				socket_nice="?";;
 			AMD_GEODE_*)
 				cpu_nice="AMD Geode™ ${cpu#AMD_GEODE_}";
@@ -274,32 +272,22 @@ EOF
 				socket_nice="Socket 939"
 				;;
 			AMD_SC520)
-				cpu_nice="AMD Élan™ SC520";
-				northbridge_nice="AMD Élan™ SC520";
-				southbridge_nice="AMD Élan™ SC520";
+				cpu_nice="AMD Élan™SC520";
 				socket_nice="—";;
 			ARMLTD_CORTEX_A9)
 				cpu_nice="ARM Cortex A9";
-				northbridge_nice="ARM Cortex A9";
-				southbridge_nice="ARM Cortex A9";
 				socket_nice="?";;
 			DMP_VORTEX86EX)
 				cpu_nice="DMP VORTEX86EX";
 				socket_nice="?";;
 			SAMSUNG_EXYNOS5420)
 				cpu_nice="Samsung Exynos 5420";
-				northbridge_nice="Samsung Exynos 5420";
-				southbridge_nice="Samsung Exynos 5420";
 				socket_nice="?";;
 			SAMSUNG_EXYNOS5250)
 				cpu_nice="Samsung Exynos 5250";
-				northbridge_nice="Samsung Exynos 5250";
-				southbridge_nice="Samsung Exynos 5250";
 				socket_nice="?";;
 			TI_AM335X)
 				cpu_nice="TI AM335X";
-				southbridge_nice="TI AM335X";
-				northbridge_nice="TI AM335X";
 				socket_nice="?";;
 			INTEL_SLOT_1)
 				cpu_nice="Intel® Pentium® II/III, Celeron®";
@@ -390,16 +378,6 @@ EOF
 				socket_nice="$cpu";;
 		esac
 
-		if [ x"$northbridge_nice" = x ]; then
-		    if grep 'select SOC_INTEL_BAYTRAIL' "$vendor_board_dir/Kconfig" > /dev/null ; then
-			southbridge_nice="Intel® Baytrail"
-			northbridge_nice="Intel® Baytrail"
-			cpu_nice="Intel® Baytrail"
-			socket_nice="—"
-		    fi
-		fi
-
-
 		echo "|- bgcolor=\"#$color\""
 		echo "| $vendor_nice"
 		echo -n "| [[Board:$vendor/$board|$board_nice]]"



More information about the coreboot-gerrit mailing list