[coreboot-gerrit] New patch to review for coreboot: 7414c5f lynxpoint: Fix SerialIO ACPI compile issue with recent IASL

Duncan Laurie (dlaurie@google.com) gerrit at coreboot.org
Mon Feb 10 20:48:04 CET 2014


Duncan Laurie (dlaurie at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5182

-gerrit

commit 7414c5f6e8bb9e585f6f604143c1d21732c69d47
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Feb 10 11:37:45 2014 -0800

    lynxpoint: Fix SerialIO ACPI compile issue with recent IASL
    
    The SerialIO DwordIo() definition is fixed up before returning
    it in the serialio device _CRS method, so the values that are set
    in the raw ASL are not actually used.
    
    However modern versions of IASL do not like that the RangeLength is
    set to zero and will fail to compile.  Set this value to 1 to make
    IASL stop complaining, but the real value is still fixed up in _CRS
    so this has no real effect on the end result.
    
    Change-Id: Iceb888e54dd4d627c12d078915108a11f45b1a2d
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/southbridge/intel/lynxpoint/acpi/serialio.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 4c0d36b..697548e 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -498,7 +498,7 @@ Device (GPIO)
 			0x00000000,  // AddressMinimum
 			0x00000000,  // AddressMaximum
 			0x00000000,  // AddressTranslation
-			0x00000000,  // RangeLength
+			0x00000001,  // RangeLength
 			,            // ResourceSourceIndex
 			,            // ResourceSource
 			BAR0)



More information about the coreboot-gerrit mailing list