[coreboot-gerrit] Patch set updated for coreboot: b50ed25 acpi/ec: Add missing delay

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Jan 6 11:21:07 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4617

-gerrit

commit b50ed256d13366513f1bc2faac7c0cc0a29d4b42
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Jan 5 06:50:10 2014 +0100

    acpi/ec: Add missing delay
    
    Without this delay on fast systems like X230 the port is read before it's
    updated.
    
    Change-Id: I3e01fc348cc5170cec108a05095ba301055ed6b0
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/ec/acpi/ec.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c
index ab287d6..634d2bb 100644
--- a/src/ec/acpi/ec.c
+++ b/src/ec/acpi/ec.c
@@ -53,6 +53,8 @@ int send_ec_command(u8 command)
 		// return -1;
 	}
 
+	udelay(10);
+
 	outb(command, ec_cmd_reg);
 	return 0;
 }
@@ -73,6 +75,8 @@ int send_ec_data(u8 data)
 		// return -1;
 	}
 
+	udelay(10);
+
 	outb(data, ec_data_reg);
 
 	return 0;
@@ -104,6 +108,8 @@ u8 recv_ec_data(void)
 		// return -1;
 	}
 
+	udelay(10);
+
 	data = inb(ec_data_reg);
 	printk(BIOS_SPEW, "recv_ec_data: 0x%02x\n", data);
 



More information about the coreboot-gerrit mailing list