[coreboot-gerrit] New patch to review for coreboot: ef0969c CAR_GLOBAL: Define section details once

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Jan 18 18:29:46 CET 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4716

-gerrit

commit ef0969cd0f88de1ef3419982afbe5cf032c39799
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Jan 18 16:38:12 2014 +0100

    CAR_GLOBAL: Define section details once
    
    Improves clang compatibility and one opaque hack less.
    
    Change-Id: I4640b0fc397b301102dde6dc3ea1a078ce9edf1c
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/arch/x86/include/arch/early_variables.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index ba7df97..ea1a133 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -21,8 +21,12 @@
 #define ARCH_EARLY_VARIABLES_H
 
 #ifdef __PRE_RAM__
-#define CAR_GLOBAL __attribute__((section(".car.global_data,\"w\", at nobits#")))
-#define CAR_CBMEM __attribute__((section(".car.cbmem_console,\"w\", at nobits#")))
+asm(".section .car.global_data,\"w\", at nobits");
+asm(".previous");
+asm(".section .car.cbmem_console,\"w\", at nobits");
+asm(".previous");
+#define CAR_GLOBAL __attribute__((section(".car.global_data")))
+#define CAR_CBMEM __attribute__((section(".car.cbmem_console")))
 #else
 #define CAR_GLOBAL
 #define CAR_CBMEM



More information about the coreboot-gerrit mailing list