[coreboot-gerrit] Patch set updated for coreboot: 05015ff lenovo/x201: Skip AT24RF08 detection.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Thu Jan 23 16:53:41 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4769

-gerrit

commit 05015ff6c5d43f91e9dfee1c30df998d63ac07e4
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Tue Jan 21 09:45:15 2014 +0100

    lenovo/x201: Skip AT24RF08 detection.
    
    AT24RF08 was inherited from RE of original BIOS. As we don't really care
    if the chip in question is really AT24RF08 or a generic replacement,
    we can skip this check.
    
    Change-Id: I862dd66b2332314beb835f215f1c1cd838aa07b9
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/lenovo/x201/romstage.c | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c
index 7935e56..c0150de 100644
--- a/src/mainboard/lenovo/x201/romstage.c
+++ b/src/mainboard/lenovo/x201/romstage.c
@@ -183,30 +183,6 @@ static void rcba_config(void)
 	}
 }
 
-static void setup_smbus_5c(void)
-{
-	u16 t3;
-
-	/* We have a muxed bus, hence all the GPIO accesses.  */
-	if (MCHBAR8(0x2ca8) == 0) {
-		t3 = inw(DEFAULT_GPIOBASE | 0x38);
-		outw(t3 & ~0x400, DEFAULT_GPIOBASE | 0x38);
-		smbus_read_byte(0x5c, 0x06);
-		smbus_write_byte(0x5c, 0x06, 0x8f);
-
-		smbus_read_byte(0x5c, 0x07);
-		smbus_write_byte(0x5c, 0x07, 0x8f);
-
-		outw(t3 | 0x400, DEFAULT_GPIOBASE | 0x38);
-	}
-
-	t3 = inw(DEFAULT_GPIOBASE | 0x38);
-	outw(t3 & ~0x400, DEFAULT_GPIOBASE | 0x38);
-
-	smbus_read_byte(0x57, 0x55);
-	outw(t3 | 0x400, DEFAULT_GPIOBASE | 0x38);
-}
-
 static inline void write_acpi32(u32 addr, u32 val)
 {
 	outl(val, DEFAULT_PMBASE | addr);
@@ -294,8 +270,6 @@ void main(unsigned long bist)
 	/* Enable SMBUS. */
 	enable_smbus();
 
-	setup_smbus_5c();
-
 	outb((inb(DEFAULT_GPIOBASE | 0x3a) & ~0x2) | 0x20,
 	     DEFAULT_GPIOBASE | 0x3a);
 	outb(0x50, 0x15ec);



More information about the coreboot-gerrit mailing list