[coreboot-gerrit] New patch to review for coreboot: 4f6ef23 baytrail: IOSF write functions need to set data before control
Aaron Durbin (adurbin@google.com)
gerrit at coreboot.org
Tue Jan 28 03:55:42 CET 2014
Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4906
-gerrit
commit 4f6ef231693a09a81b95f8ada43271e5efd48ee7
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Mon Oct 28 14:18:38 2013 -0700
baytrail: IOSF write functions need to set data before control
The data needs to be available in the register before the control
bits are set to make the write happen.
BUG=chrome-os-partner:23507
BRANCH=rambi
TEST=successfully ungate power on PUNIT on rambi
Change-Id: I8fae60d5385ce9a401c1dec9cbb39b70d157a6c2
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174898
Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/soc/intel/baytrail/iosf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/soc/intel/baytrail/iosf.c b/src/soc/intel/baytrail/iosf.c
index e35e34f..b9f1531 100644
--- a/src/soc/intel/baytrail/iosf.c
+++ b/src/soc/intel/baytrail/iosf.c
@@ -56,8 +56,8 @@ void iosf_bunit_write(int reg, uint32_t val)
uint32_t cr = IOSF_OPCODE(IOSF_OP_WRITE_BUNIT) |
IOSF_PORT(IOSF_PORT_BUNIT) | IOSF_REG(reg) | IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_dunit_read(int reg)
@@ -91,8 +91,8 @@ void iosf_dunit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_SYSMEMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_punit_read(int reg)
@@ -111,6 +111,6 @@ void iosf_punit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_PMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}
More information about the coreboot-gerrit
mailing list