[coreboot-gerrit] New patch to review for coreboot: 98d634a baytrail: don't SMI on tco timer firing

[Aaron Durbin (adurbin@google.com)]

Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5035

-gerrit

commit 98d634a99a8e6a6ae84627e2beb6fb1e990e8208
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Jan 9 10:44:06 2014 -0600

    baytrail: don't SMI on tco timer firing
    
    The SMI on TCO timer timeout policy was copied from other
    chipsets. However, it's not very advantageous to have
    the TCO timer timeout trigger an SMI unless the firmware
    was the one responsible for setting up the timer.
    
    BUG=chromium:321832
    BRANCH=rambi,squawks
    TEST=Manually enabled TCO timer. TCO fires and logged in
         eventlog.
    
    Change-Id: I420b14d6aa778335a925784a64160fa885cba20f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/181985
---
 src/soc/intel/baytrail/smm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/baytrail/smm.c b/src/soc/intel/baytrail/smm.c
index 1fb35d7..d4b3d58 100644
--- a/src/soc/intel/baytrail/smm.c
+++ b/src/soc/intel/baytrail/smm.c
@@ -102,14 +102,14 @@ void southcluster_smm_enable_smi(void)
 	southcluster_smm_route_gpios();
 
 	/* Enable SMI generation:
-	 *  - on TCO events
 	 *  - on APMC writes (io 0xb2)
 	 *  - on writes to SLP_EN (sleep states)
 	 *  - on writes to GBL_RLS (bios commands)
 	 * No SMIs:
+	 *  - on TCO events
 	 *  - on microcontroller writes (io 0x62/0x66)
 	 */
-	enable_smi(TCO_EN | APMC_EN | SLP_SMI_EN | GBL_SMI_EN | EOS);
+	enable_smi(APMC_EN | SLP_SMI_EN | GBL_SMI_EN | EOS);
 }
 
 void smm_setup_structures(void *gnvs, void *tcg, void *smi1)