[coreboot-gerrit] New patch to review for coreboot: fab328c baytrail: use CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED

[Aaron Durbin (adurbin@google.com)]

Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5048

-gerrit

commit fab328c58e508f2206875016d5cf0bc9e9f8915d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Jan 14 17:34:10 2014 -0600

    baytrail: use CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
    
    On baytrail, it appears that the turbo disable setting is
    actually building-block scoped. One can see this on quad
    core parts where if enable_turbo() is called only on the
    BSP then only cpus 0 and 1 have turbo enabled. Fix this
    by calling enable_turbo() on all non-bsp cpus.
    
    BUG=chrome-os-partner:25014
    BRANCH=baytrail
    TEST=Built and booted rambi. All cpus have bit 38 set to 0
         in msr 0x1a0.
    
    Change-Id: Id493e070c4a70bb236cdbd540d2321731a99aec2
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/182406
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/baytrail/Kconfig | 1 +
 src/soc/intel/baytrail/cpu.c   | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig
index a17852d..5aacbdc 100644
--- a/src/soc/intel/baytrail/Kconfig
+++ b/src/soc/intel/baytrail/Kconfig
@@ -14,6 +14,7 @@ config CPU_SPECIFIC_OPTIONS
 	select CAR_MIGRATION
 	select COLLECT_TIMESTAMPS
 	select CPU_MICROCODE_IN_CBFS
+	select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
 	select DYNAMIC_CBMEM
 	select HAVE_MONOTONIC_TIMER
 	select HAVE_SMI_HANDLER
diff --git a/src/soc/intel/baytrail/cpu.c b/src/soc/intel/baytrail/cpu.c
index cf32c54..aff6c55 100644
--- a/src/soc/intel/baytrail/cpu.c
+++ b/src/soc/intel/baytrail/cpu.c
@@ -92,7 +92,7 @@ void baytrail_init_cpus(device_t dev)
 	/* Set package MSRs */
 	reg_script_run(package_msr_script);
 
-	/* Enable Turbo/Burst Mode */
+	/* Enable Turbo Mode on BSP and siblings of the BSP's building block. */
 	enable_turbo();
 
 	if (mp_init(cpu_bus, &mp_params)) {
@@ -104,6 +104,13 @@ static void baytrail_core_init(device_t cpu)
 {
 	printk(BIOS_DEBUG, "Init BayTrail core.\n");
 
+	/* On bay trail the turbo disable bit is actually scoped at building
+	 * block level -- not package. For non-bsp cores that are within a
+	 * building block enable turbo. The cores within the BSP's building
+	 * block will just see it already enabled and move on. */
+	if (lapicid())
+		enable_turbo();
+
 	/* Set core MSRs */
 	reg_script_run(core_msr_script);