[coreboot-gerrit] Patch merged into coreboot/master: 88d5fb9 cbfs: fix issues with word size and endianness.

gerrit at coreboot.org gerrit at coreboot.org
Wed Jan 29 20:03:46 CET 2014


the following patch was just integrated into master:
commit 88d5fb9060920e9b28bd373b204e0f2a38b96918
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Tue Dec 3 11:13:35 2013 -0800

    cbfs: fix issues with word size and endianness.
    
    Add XDR functions and use them to convert the ELF headers
    to native headers, using the Elf64 structs to ensure we accomodate
    all word sizes. Also, use these XDR functions for output.
    
    This may seem overly complex but it turned out to be much the easiest
    way to do this. Note that the basic elf parsing function
    in cbfs-mkstage.c now works over all ELF files, for all architectures,
    endian, and word size combinations. At the same time, the basic elf
    parsing in cbfs-mkstage.c is a loop that has no architecture-specific
    conditionals.
    
    Add -g to the LDFLAGS while we're here. It's on the CFLAGS so there is
    no harm done.
    
    This code has been tested on all chromebooks that use coreboot to date.
    
    I added most of the extra checks from ChromeOS and they triggered a
    lot of warnings, hence the other changes. I had to take -Wshadow back
    out due to the many errors it triggers in LZMA.
    
    BUG=None
    TEST=Build and boot for Peppy; works fine. Build and boot for nyan,
         works fine. Build for qemu targets and armv8 targets.
    BRANCH=None
    
    Change-Id: I5a4cee9854799189115ac701e22efc406a8d902f
    Signed-off-by: Ronald G. Minnich <rminnich at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/178606
    Reviewed-by: Ronald Minnich <rminnich at chromium.org>
    Commit-Queue: Ronald Minnich <rminnich at chromium.org>
    Tested-by: Ronald Minnich <rminnich at chromium.org>


See http://review.coreboot.org/4817 for details.

-gerrit



More information about the coreboot-gerrit mailing list