[coreboot-gerrit] Patch set updated for coreboot: d612ed4 jetway/nf81-t56n-lf: Serialize ACPI methods to avoid races.

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jan 30 10:59:57 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5079

-gerrit

commit d612ed42cd515478486cd048a80fe82aaa6599df
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed Jan 29 15:29:44 2014 +1100

    jetway/nf81-t56n-lf: Serialize ACPI methods to avoid races.
    
    Fix the remark introduced in ACPICA version 20130517 that gives the
    following explanation:
    
       If a thread blocks within the method for any reason, and another thread
       enters the method, the method will fail because an attempt will be
       made to create the same (named) object twice.
    
       In this case, issue a remark that the method should be marked
       serialized. ACPICA BZ 909.
    
    Change-Id: I2b3605a31a8647c07be0830e54cd117d53985c81
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
 	Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
 	{
 		NAME(OTBF, Buffer(20) { /* out buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
 		Return(OTBF) /* out buffer */
 	}				/* End Method(_GTM) */
 
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
 	{
 		NAME(INBF, Buffer(20) { /* in buffer */
 			0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
 	Device(MST)
 	{
 		Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
 	Device(SLAV)
 	{
 		Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
 			Name(CMBF, Buffer(21) {
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
 				0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,



More information about the coreboot-gerrit mailing list