[coreboot-gerrit] New patch to review for coreboot: 94b0c3d amd/cimx: fix sb(8|9)00 NULL type redefine
Aaron Durbin (adurbin@google.com)
gerrit at coreboot.org
Fri Jan 31 05:21:16 CET 2014
Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5088
-gerrit
commit 94b0c3dd50d85a841cb168e919c2fc358a8c32a7
Author: Aaron Durbin <adurbin at chromium.org>
Date: Thu Jan 30 22:20:01 2014 -0600
amd/cimx: fix sb(8|9)00 NULL type redefine
It is inappropriate for chipset code to be redefining
types -- especially NULL to a non-pointer type.
Change-Id: Iab5733e5a573baba6fec94e0c955ba4fad72c836
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/southbridge/amd/cimx/sb800/SBPLATFORM.h | 6 +-----
src/southbridge/amd/cimx/sb900/SbPlatform.h | 6 +-----
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/southbridge/amd/cimx/sb800/SBPLATFORM.h b/src/southbridge/amd/cimx/sb800/SBPLATFORM.h
index fa7d196..ea3f719 100644
--- a/src/southbridge/amd/cimx/sb800/SBPLATFORM.h
+++ b/src/southbridge/amd/cimx/sb800/SBPLATFORM.h
@@ -24,11 +24,7 @@
#ifndef _AMD_SBPLATFORM_H_
#define _AMD_SBPLATFORM_H_
-//#include "cbtypes.h"
-#ifdef NULL
- #undef NULL
-#endif
-#define NULL 0
+#include <stddef.h>
typedef unsigned long long PLACEHOLDER;
diff --git a/src/southbridge/amd/cimx/sb900/SbPlatform.h b/src/southbridge/amd/cimx/sb900/SbPlatform.h
index 5e41978..176ad87 100644
--- a/src/southbridge/amd/cimx/sb900/SbPlatform.h
+++ b/src/southbridge/amd/cimx/sb900/SbPlatform.h
@@ -24,11 +24,7 @@
#ifndef _AMD_SBPLATFORM_H_
#define _AMD_SBPLATFORM_H_
-//#include "cbtypes.h"
-#ifdef NULL
- #undef NULL
-#endif
-#define NULL 0
+#include <stddef.h>
typedef unsigned long long PLACEHOLDER;
More information about the coreboot-gerrit
mailing list