[coreboot-gerrit] Patch merged into coreboot/master: 77d1280 SPI flash: Fix alignment checks in Page Program commands

gerrit at coreboot.org gerrit at coreboot.org
Mon Jul 14 19:42:29 CEST 2014


the following patch was just integrated into master:
commit 77d1280d0c866a9f85e62f74c43fe8d021a4ff39
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sun Jun 29 16:15:39 2014 +0300

    SPI flash: Fix alignment checks in Page Program commands
    
    There are two separate restrictions to take into account:
    
      Page Program command must not cross address boundaries defined by the
      flash part's page size.
    
      Total number of bytes for any command sent to flash part is restricted
      by the SPI controller capabilities.
    
    Consider
    
      CONTROLLER_PAGE_LIMIT=64, page_size=256, offset=62, len=4.
      This write would be split at offset 64 for no reason.
    
    Consider
    
      CONTROLLER_PAGE_LIMIT=40, page_size=256, offset=254, len=4.
      This write would not be split at page boundary as required.
    
    We do not really hit the second case. Nevertheless, CONTROLLER_PAGE_LIMIT
    is a misnomer for the maximum payload length supported by the SPI controller
    and is removed in a followup.
    
    Change-Id: I727f2e7de86a91b6a509460ff1f374acd006a0bc
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: http://review.coreboot.org/6162
    Tested-by: build bot (Jenkins)
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>


See http://review.coreboot.org/6162 for details.

-gerrit



More information about the coreboot-gerrit mailing list