[coreboot-gerrit] Patch merged into coreboot/master: 3bb0b72 util/xcompile: Print fatal error messages to stderr instead of stdout

gerrit at coreboot.org gerrit at coreboot.org
Tue Jul 15 11:03:37 CEST 2014


the following patch was just integrated into master:
commit 3bb0b7230c07cb1d5b71df6976a8323c1cb41ca0
Author: Daniele Forsi <dforsi at gmail.com>
Date:   Mon Jul 14 15:35:42 2014 +0200

    util/xcompile: Print fatal error messages to stderr instead of stdout
    
    This uses die() which was previously unused.
    Before this change an unhelpful error message was printed when make tried
    to parse English text as if it was part of the makefile:
    .xcompile:1: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.
    
    After this change the first error message at least mentions that iasl is
    missing:
    ERROR: no iasl found
    make: -print-libgcc-file-name: Command not found
    make: -print-libgcc-file-name: Command not found
    make: -print-libgcc-file-name: Command not found
    /bin/sh: 0: Illegal option -
    Makefile.inc:36: *** Please use the coreboot toolchain (or prove that your toolchain works).  Stop.
    
    Change-Id: I79d5de5993e3828460130192df376daa55f32aa0
    Signed-off-by: Daniele Forsi <dforsi at gmail.com>
    Reviewed-on: http://review.coreboot.org/6272
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <gaumless at gmail.com>


See http://review.coreboot.org/6272 for details.

-gerrit



More information about the coreboot-gerrit mailing list