[coreboot-gerrit] New patch to review for coreboot: d0be74d build system: fix another cbfstool race

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Jul 15 12:29:48 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6276

-gerrit

commit d0be74dc358f5cd4d64feaa3772140b4487ecc6a
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Tue Jul 15 12:28:12 2014 +0200

    build system: fix another cbfstool race
    
    It just doesn't work to have files depend on their parent
    directory: As soon as the files are written, the time stamp
    of the directory changes, too.
    
    This led to spurious updates of cbfstool and rmodtool, and
    related "permission denied" errors when linker and build
    system ran into each other.
    
    Change-Id: I44a7d7b4b1d47a1567ece1f57dfd6745d05ee651
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/cbfstool/Makefile.inc | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index 0548ea4..410d96c 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -27,9 +27,6 @@ ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32)
 TOOLFLAGS+=-mno-ms-bitfields
 endif
 
-$(objutil)/cbfstool:
-	mkdir -p $@
-
 $(objutil)/cbfstool/%.o: $(top)/util/cbfstool/%.c
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@))\n"
 	$(HOSTCC) $(TOOLFLAGS) $(HOSTCFLAGS) -c -o $@ $<
@@ -42,10 +39,10 @@ $(objutil)/cbfstool/%.o: $(top)/util/cbfstool/lzma/C/%.c
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@))\n"
 	$(HOSTCC) $(TOOLFLAGS) $(HOSTCFLAGS) -c -o $@ $<
 
-$(objutil)/cbfstool/cbfstool: $(objutil)/cbfstool $(addprefix $(objutil)/cbfstool/,$(cbfsobj))
+$(objutil)/cbfstool/cbfstool: $(addprefix $(objutil)/cbfstool/,$(cbfsobj))
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@)) (link)\n"
 	$(HOSTCC) $(TOOLFLAGS) -o $@ $(addprefix $(objutil)/cbfstool/,$(cbfsobj))
 
-$(objutil)/cbfstool/rmodtool: $(objutil)/cbfstool $(addprefix $(objutil)/cbfstool/,$(rmodobj))
+$(objutil)/cbfstool/rmodtool: $(addprefix $(objutil)/cbfstool/,$(rmodobj))
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@)) (link)\n"
 	$(HOSTCC) $(TOOLFLAGS) -o $@ $(addprefix $(objutil)/cbfstool/,$(rmodobj))



More information about the coreboot-gerrit mailing list