[coreboot-gerrit] Patch set updated for coreboot: da56592 mainboard/supermicro/h8dme: Drop unused code
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Tue Jun 3 10:31:20 CEST 2014
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5828
-gerrit
commit da565920f3fff63432746e14cf511450423174c2
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Sat May 24 01:45:41 2014 +1000
mainboard/supermicro/h8dme: Drop unused code
Clang complains about a unused debug function, so remove dead code.
We have copy of dump_smbus_registers() in amdk8/debug.c.
Change-Id: I5a9a785fcd90761789aaa029f712f1feddd2afd1
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/mainboard/supermicro/h8dme/romstage.c | 63 -------------------------------
1 file changed, 63 deletions(-)
diff --git a/src/mainboard/supermicro/h8dme/romstage.c b/src/mainboard/supermicro/h8dme/romstage.c
index 47f5806..100a0e8 100644
--- a/src/mainboard/supermicro/h8dme/romstage.c
+++ b/src/mainboard/supermicro/h8dme/romstage.c
@@ -45,69 +45,6 @@
static void memreset(int controllers, const struct mem_controller *ctrl) { }
-static inline void dump_smbus_registers(void)
-{
- u32 device;
-
- print_debug("\n");
- for (device = 1; device < 0x80; device++) {
- int j;
- if (smbus_read_byte(device, 0) < 0)
- continue;
- printk(BIOS_DEBUG, "smbus: %02x", device);
- for (j = 0; j < 256; j++) {
- int status;
- unsigned char byte;
- status = smbus_read_byte(device, j);
- if (status < 0) {
- break;
- }
- if ((j & 0xf) == 0) {
- printk(BIOS_DEBUG, "\n%02x: ", j);
- }
- byte = status & 0xff;
- printk(BIOS_DEBUG, "%02x ", byte);
- }
- print_debug("\n");
- }
-}
-
-static inline void activate_spd_rom(const struct mem_controller *ctrl)
-{
-#if 0
-/* We don't do any switching yet. */
-#define SMBUS_SWITCH1 0x48
-#define SMBUS_SWITCH2 0x49
- unsigned device=(ctrl->channel0[0])>>8;
- smbus_send_byte(SMBUS_SWITCH1, device);
- smbus_send_byte(SMBUS_SWITCH2, (device >> 4) & 0x0f);
-#endif
-}
-
-#if 0
-static int smbus_send_byte_one(unsigned device, unsigned char val)
-{
- return do_smbus_send_byte(SMBUS1_IO_BASE, device, val);
-}
-
-static inline void change_i2c_mux(unsigned device)
-{
-#define SMBUS_SWITCH1 0x48
-#define SMBUS_SWITHC2 0x49
- smbus_send_byte(SMBUS_SWITCH1, device & 0x0f);
- smbus_send_byte_one(SMBUS_SWITCH2, (device >> 4) & 0x0f);
- int ret;
- print_debug("change_i2c_mux i="); print_debug_hex8(device); print_debug("\n");
- dump_smbus_registers();
- ret = smbus_send_byte(SMBUS_SWITCH1, device);
- print_debug("change_i2c_mux ret="); print_debug_hex32(ret); print_debug("\n");
- dump_smbus_registers();
- ret = smbus_send_byte_one(SMBUS_SWITCH2, device);
- print_debug("change_i2c_mux ret="); print_debug_hex32(ret); print_debug("\n");
- dump_smbus_registers();
-}
-#endif
-
static inline int spd_read_byte(unsigned device, unsigned address)
{
return smbus_read_byte(device, address);
More information about the coreboot-gerrit
mailing list