[coreboot-gerrit] New patch to review for coreboot: dbe42be Lenovo x60: use defined LPC_GEN*_DEC for LPC dev

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Mon Jun 9 09:25:04 CEST 2014


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5962

-gerrit

commit dbe42be9b9851244af97bdb0a279815a6cfd92f9
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Mon Jun 9 09:22:31 2014 +0200

    Lenovo x60: use defined LPC_GEN*_DEC for LPC dev
    
    Change-Id: I52c1457aa5051b3ee4538251a96726817979a70b
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/mainboard/lenovo/x60/romstage.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c
index 3e66709..cff16dc 100644
--- a/src/mainboard/lenovo/x60/romstage.c
+++ b/src/mainboard/lenovo/x60/romstage.c
@@ -91,16 +91,13 @@ static void ich7_enable_lpc(void)
 	pci_write_config16(LPC_DEV, LPC_EN, 0x1f0d);
 
 	/* range 0x1600 - 0x167f */
-	pci_write_config16(LPC_DEV, 0x84, 0x1601);
-	pci_write_config16(LPC_DEV, 0x86, 0x007c);
+	pci_write_config32(LPC_DEV, LPC_GEN1_DEC, 0x007c1601);
 
 	/* range 0x15e0 - 0x10ef */
-	pci_write_config16(LPC_DEV, 0x88, 0x15e1);
-	pci_write_config16(LPC_DEV, 0x8a, 0x000c);
+	pci_write_config32(LPC_DEV, LPC_GEN2_DEC, 0x000c15e1);
 
 	/* range 0x1680 - 0x169f */
-	pci_write_config16(LPC_DEV, 0x8c, 0x1681);
-	pci_write_config16(LPC_DEV, 0x8e, 0x001c);
+	pci_write_config32(LPC_DEV, LPC_GEN3_DEC, 0x001c1681);
 }
 
 static void early_superio_config(void)



More information about the coreboot-gerrit mailing list