[coreboot-gerrit] New patch to review for coreboot: 88c3b84 lippert/toucan-af: Fix comment on HAVE_ACPI_RESUME

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Jun 11 15:16:36 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5971

-gerrit

commit 88c3b84549bb4c8b1b1eb79d57a399334f212d40
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jun 6 22:57:01 2014 +0300

    lippert/toucan-af: Fix comment on HAVE_ACPI_RESUME
    
    S3 resume is expected to work now, however the 3s delay and flash wear
    is still there.
    
    Change-Id: I7edbce7bcf9c2160099fd5e371562b1ec63d45d8
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/lippert/toucan-af/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mainboard/lippert/toucan-af/Kconfig b/src/mainboard/lippert/toucan-af/Kconfig
index 491433d..275f9e5 100644
--- a/src/mainboard/lippert/toucan-af/Kconfig
+++ b/src/mainboard/lippert/toucan-af/Kconfig
@@ -30,9 +30,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_OPTION_TABLE
 	select HAVE_PIRQ_TABLE
 	select HAVE_MP_TABLE
-	# S3 doesn't work yet, heapManager.c:576 failed last time I tried,
-	# couldn't figure out why.  But s3_resume.c (look for "spi_flash_probe")
-	# erases 28 KB and writes 10 KB register dumps to SPI flash on every
+	# This erases 28 KB and writes 10 KB register dumps to SPI flash on every
 	# boot, wasting 3 s and causing wear!  Therefore disable S3 for now.
 	#select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES



More information about the coreboot-gerrit mailing list