[coreboot-gerrit] New patch to review for coreboot: 3d211be device/pci_device.c: Sanitize headers

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Fri Jun 20 13:20:27 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6079

-gerrit

commit 3d211be56672e5d17e7b17cca56732db0e02ea21
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Jun 20 21:19:06 2014 +1000

    device/pci_device.c: Sanitize headers
    
    Change-Id: I6254f4ab767952cc8ff31bb462c7037b027442ba
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/device/pci_device.c | 32 ++++++++------------------------
 1 file changed, 8 insertions(+), 24 deletions(-)

diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 3a54c2d..9c40d8a 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -24,41 +24,25 @@
  * Copyright 1997 -- 1999 Martin Mares <mj at atrey.karlin.mff.cuni.cz>
  */
 
-#include <kconfig.h>
+#include <arch/acpi.h>
+#include <arch/io.h>
+#include <bootmode.h>
 #include <console/console.h>
 #include <stdlib.h>
 #include <stdint.h>
 #include <string.h>
-#include <arch/io.h>
+#include <delay.h>
+#include <device/agp.h>
+#include <device/cardbus.h>
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
-#include <bootmode.h>
-#include <delay.h>
-#if CONFIG_HYPERTRANSPORT_PLUGIN_SUPPORT
-#include <device/hypertransport.h>
-#endif
-#if CONFIG_PCIX_PLUGIN_SUPPORT
 #include <device/pcix.h>
-#endif
-#if CONFIG_PCIEXP_PLUGIN_SUPPORT
 #include <device/pciexp.h>
-#endif
-#if CONFIG_AGP_PLUGIN_SUPPORT
-#include <device/agp.h>
-#endif
-#if CONFIG_CARDBUS_PLUGIN_SUPPORT
-#include <device/cardbus.h>
-#endif
-#if CONFIG_PC80_SYSTEM
+#include <device/hypertransport.h>
 #include <pc80/i8259.h>
-#endif
-#if CONFIG_HAVE_ACPI_RESUME && !CONFIG_S3_VGA_ROM_RUN
-#include <arch/acpi.h>
-#endif
-#if CONFIG_CHROMEOS
+#include <kconfig.h>
 #include <vendorcode/google/chromeos/chromeos.h>
-#endif
 
 u8 pci_moving_config8(struct device *dev, unsigned int reg)
 {



More information about the coreboot-gerrit mailing list