[coreboot-gerrit] Patch set updated for coreboot: dc5ee89 build: Pass correct disassembly flags in Clang build

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jun 26 12:50:45 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5813

-gerrit

commit dc5ee8921b9999f41847a88a72ed82292c0803d3
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri May 23 01:32:44 2014 +1000

    build: Pass correct disassembly flags in Clang build
    
    On SVR4-derived platforms, the character `/' is treated as a comment
    character, which means that it cannot be used in expressions. The
    `--divide' option turns `/' into a normal character. This seems to be
    needed with our local build of binutils since we don't yet use the
    internal assembler/disassembler of the Clang tooling.
    
    Change-Id: I344fc8670fd5d994f3b63308a513dd367aefc7f9
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 125e9de..c0e908d 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -30,7 +30,7 @@ subdirs-y += smp
 ifeq ($(CONFIG_COMPILER_GCC),y)
 DISASSEMBLY=-Wa,-acdlns
 else
-DISASSEMBLY=
+DISASSEMBLY=-Wa,--divide
 endif
 
 OPTION_TABLE_H:=



More information about the coreboot-gerrit mailing list