[coreboot-gerrit] New patch to review for coreboot: 5c76dae northbridge/amd/gx2/raminit.c Halt func needs noreturn attrib

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sat Jun 28 18:33:16 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6157

-gerrit

commit 5c76daed53f13a09741b26f6b409ba04c77a4951
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Jun 29 02:27:19 2014 +1000

    northbridge/amd/gx2/raminit.c Halt func needs noreturn attrib
    
    Missing "__attribute__((noreturn))" on halt function. This sync's the
    implementation to be the same as that of amd/lx thereby avoiding
    compiler warnings.
    
    Change-Id: Iead16125805eb36ff875fba767cf8d4e5aa86715
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/gx2/raminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/amd/gx2/raminit.c b/src/northbridge/amd/gx2/raminit.c
index 71d0a16..d9af161 100644
--- a/src/northbridge/amd/gx2/raminit.c
+++ b/src/northbridge/amd/gx2/raminit.c
@@ -26,7 +26,7 @@ static const unsigned char NumColAddr[] = {
 	0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F,
 };
 
-static void hcf(void)
+static void __attribute__((noreturn)) hcf(void)
 {
 	printk(BIOS_EMERG, "DIE\n");
 	/* this guarantees we flush the UART fifos (if any) and also



More information about the coreboot-gerrit mailing list