[coreboot-gerrit] New patch to review for coreboot: 0435c30 CBMEM console: Fix build for ARM

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sun Mar 9 12:50:13 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5356

-gerrit

commit 0435c30b4344e36bd100179173e6e4aed66796db
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sun Mar 9 13:46:48 2014 +0200

    CBMEM console: Fix build for ARM
    
    This preprocessor guard was used to disable CBMEM console from
    romstage of ROMCC boards. It unintentionally disabled it for ARM
    too as the do not have CACHE_AS_RAM selected.
    
    Option EARLY_CBMEM_INIT implies CAR migration which is required
    to have CBMEM console in romstage. This change should have been
    done in commit f8bf5a10 already, but we missed it.
    
    Change-Id: I03e95183be0e78bc7dd439d5fef5b10e54966dc3
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/include/console/cbmem_console.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/console/cbmem_console.h b/src/include/console/cbmem_console.h
index 69332aa..4f4a54f 100644
--- a/src/include/console/cbmem_console.h
+++ b/src/include/console/cbmem_console.h
@@ -19,7 +19,7 @@
 #ifndef _CONSOLE_CBMEM_CONSOLE_H_
 #define _CONSOLE_CBMEM_CONSOLE_H_
 
-#if CONFIG_CACHE_AS_RAM || !defined(__PRE_RAM__)
+#if CONFIG_EARLY_CBMEM_INIT || !defined(__PRE_RAM__)
 void cbmemc_init(void);
 void cbmemc_reinit(void);
 void cbmemc_tx_byte(unsigned char data);



More information about the coreboot-gerrit mailing list