[coreboot-gerrit] New patch to review for coreboot: 5822332 lenovo/x60: Remove duplicate console_init()

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5433

-gerrit

commit 5822332b263571e1a81d4d349bc67a056148d7df
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Mar 31 00:09:23 2014 +0300

    lenovo/x60: Remove duplicate console_init()
    
    For romstage, console_init() was called twice. The one in dock_connect()
    should have done only UART programming and not touch CBMEM console and/or
    USBDEBUG when those are enabled.
    
    Second case where dock_connect() is called is in SMI handler.
    If DEBUG_SMI is not enabled, console_init() does nothing in SMM.
    If DEBUG_SMI is enabled, console_init() is already called every time when
    enterining SMM.
    
    Change-Id: Ib3a842442cb7a5be9d6b71682cd6f368930af886
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/lenovo/x60/dock.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mainboard/lenovo/x60/dock.c b/src/mainboard/lenovo/x60/dock.c
index 1b15a6c..1f85281 100644
--- a/src/mainboard/lenovo/x60/dock.c
+++ b/src/mainboard/lenovo/x60/dock.c
@@ -237,7 +237,6 @@ int dock_connect(void)
 
 	dock_write_register(0x07, 0x03);
 	dock_write_register(0x30, 0x01);
-	console_init();
 	return 0;
 }