[coreboot-gerrit] New patch to review for coreboot: 6d69996 superio/fintek/f71872: [3/4] Avoid .c includes

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5436

-gerrit

commit 6d69996950e198ec5bb1836d958fa79404579872
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Mar 31 15:13:07 2014 +1100

    superio/fintek/f71872: [3/4] Avoid .c includes
    
    Following the same reasoning as commit
    d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid
    .c includes
    Clean up the early_serial #include directives in mainboard/romstage code.
    
    Change-Id: Ia021229154dc90b830a314f3adc2a0dd444bd68d
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/superio/fintek/f71872/Makefile.inc   | 1 +
 src/superio/fintek/f71872/chip.h         | 2 +-
 src/superio/fintek/f71872/early_serial.c | 2 +-
 src/superio/fintek/f71872/f71872.h       | 4 +++-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/superio/fintek/f71872/Makefile.inc b/src/superio/fintek/f71872/Makefile.inc
index ed40eb0..58ba5d5 100644
--- a/src/superio/fintek/f71872/Makefile.inc
+++ b/src/superio/fintek/f71872/Makefile.inc
@@ -18,4 +18,5 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 ##
 
+romstage-$(CONFIG_SUPERIO_FINTEK_F71872) += early_serial.c
 ramstage-$(CONFIG_SUPERIO_FINTEK_F71872) += superio.c
diff --git a/src/superio/fintek/f71872/chip.h b/src/superio/fintek/f71872/chip.h
index a6ac51f..3368ef2 100644
--- a/src/superio/fintek/f71872/chip.h
+++ b/src/superio/fintek/f71872/chip.h
@@ -28,4 +28,4 @@ struct superio_fintek_f71872_config {
 	struct pc_keyboard keyboard;
 };
 
-#endif
+#endif /* SUPERIO_FINTEK_F71872_CHIP_H */
diff --git a/src/superio/fintek/f71872/early_serial.c b/src/superio/fintek/f71872/early_serial.c
index af5cdb3..3de7c90 100644
--- a/src/superio/fintek/f71872/early_serial.c
+++ b/src/superio/fintek/f71872/early_serial.c
@@ -36,7 +36,7 @@ static void pnp_exit_conf_state(device_t dev)
 	outb(0xaa, port);
 }
 
-static void f71872_enable_serial(device_t dev, u16 iobase)
+void f71872_enable_serial(device_t dev, u16 iobase)
 {
 	pnp_enter_conf_state(dev);
 	pnp_set_logical_device(dev);
diff --git a/src/superio/fintek/f71872/f71872.h b/src/superio/fintek/f71872/f71872.h
index 585b142..577f8d1 100644
--- a/src/superio/fintek/f71872/f71872.h
+++ b/src/superio/fintek/f71872/f71872.h
@@ -32,4 +32,6 @@
 #define F71872_VID	0x07	/* VID */
 #define F71872_PM	0x0a	/* ACPI/PME */
 
-#endif
+void f71872_enable_serial(device_t dev, u16 iobase);
+
+#endif /* SUPERIO_FINTEK_F71872_F71872_H */