[coreboot-gerrit] Patch set updated for coreboot: 5ca3aaa rambi: Fix eDP panel functionality
Aaron Durbin (adurbin@google.com)
gerrit at coreboot.org
Tue May 6 01:02:04 CEST 2014
Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4944
-gerrit
commit 5ca3aaad97355851d0420775afb9095428bd4142
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Wed Nov 6 10:58:46 2013 -0800
rambi: Fix eDP panel functionality
For some mysterious reason GPIO_S0_NC22 is making the eDP panel
go entirely white when it is configured with internal pullup.
Since these (supposedly XDP related) pins are unknown functionality
lets set them to GPIO_DEFAULT instead of GPIO_NC.
Additionally the VBIOS is being changed to issue int15 callback
to determine the boot graphics device. If we list both LFP and EFP
then the dev/rec screens will show on the panel when HDMI is not
attached and otherwise will display on HDMI.
BUG=chrome-os-partner:23507
BRANCH=rambi
TEST=build and boot on rambi, see firmware/kernel screens on the panel
when HDMI is not attached, and firmware screens on the panel and
kernel screens on both when HDMI is attached.
Change-Id: Ieb05a591d63c4f8e09fa154eeb76004d32579508
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/175952
Reviewed-by: Shawn Nematbakhsh <shawnn at chromium.org>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/mainboard/google/rambi/gpio.c | 18 +++++++++---------
src/mainboard/google/rambi/mainboard.c | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mainboard/google/rambi/gpio.c b/src/mainboard/google/rambi/gpio.c
index d7082be..9919d30 100644
--- a/src/mainboard/google/rambi/gpio.c
+++ b/src/mainboard/google/rambi/gpio.c
@@ -38,15 +38,15 @@ static const struct soc_gpio_map gpncore_gpio_map[] = {
GPIO_NC, /* S0_NC12 - NC */
GPIO_INPUT, /* S0_NC13 - GPIO_NC13 - STRAP */
GPIO_NC, /* S0_NC14 - NC */
- GPIO_NC, /* S0_NC15 - XDP_GPIO_S0_NC15 */
- GPIO_NC, /* S0_NC16 - XDP_GPIO_S0_NC16 */
- GPIO_NC, /* S0_NC17 - XDP_GPIO_S0_NC17 */
- GPIO_NC, /* S0_NC18 - XDP_GPIO_S0_NC18 */
- GPIO_NC, /* S0_NC19 - XDP_GPIO_S0_NC19 */
- GPIO_NC, /* S0_NC20 - XDP_GPIO_S0_NC20 */
- GPIO_NC, /* S0_NC21 - XDP_GPIO_S0_NC21 */
- GPIO_NC, /* S0_NC22 - XDP_GPIO_S0_NC22 */
- GPIO_NC, /* S0_NC23 - XDP_GPIO_S0_NC23 */
+ GPIO_DEFAULT, /* S0_NC15 - XDP_GPIO_S0_NC15 */
+ GPIO_DEFAULT, /* S0_NC16 - XDP_GPIO_S0_NC16 */
+ GPIO_DEFAULT, /* S0_NC17 - XDP_GPIO_S0_NC17 */
+ GPIO_DEFAULT, /* S0_NC18 - XDP_GPIO_S0_NC18 */
+ GPIO_DEFAULT, /* S0_NC19 - XDP_GPIO_S0_NC19 */
+ GPIO_DEFAULT, /* S0_NC20 - XDP_GPIO_S0_NC20 */
+ GPIO_DEFAULT, /* S0_NC21 - XDP_GPIO_S0_NC21 */
+ GPIO_DEFAULT, /* S0_NC22 - XDP_GPIO_S0_NC22 */
+ GPIO_DEFAULT, /* S0_NC23 - XDP_GPIO_S0_NC23 */
GPIO_NC, /* S0_NC24 - NC */
GPIO_NC, /* S0_NC25 - NC */
GPIO_NC, /* S0_NC26 - NC */
diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c
index 8c5b666..4ef8a9f 100644
--- a/src/mainboard/google/rambi/mainboard.c
+++ b/src/mainboard/google/rambi/mainboard.c
@@ -75,7 +75,7 @@ static int int15_handler(void)
* bit 7 = LFP2
*/
X86_AX = 0x005f;
- X86_CX = 0x0000;
+ X86_CX = 0x0006;
res = 1;
break;
case 0x5f51:
More information about the coreboot-gerrit
mailing list