[coreboot-gerrit] Patch merged into coreboot/master: f220df6 nyan: Use asm volatile instead of plain asm so it doesn't get optimized out.
gerrit at coreboot.org
gerrit at coreboot.org
Wed Nov 12 02:25:07 CET 2014
the following patch was just integrated into master:
commit f220df6ff9876fdc3f9e3abc08f0965ac4f55814
Author: Gabe Black <gabeblack at google.com>
Date: Sat Feb 8 05:01:06 2014 -0800
nyan: Use asm volatile instead of plain asm so it doesn't get optimized out.
If an asm blob isn't marked as volatile, gcc is free to throw it out if it
doesn't think it produces any values that are actually used. To prevent that
from happening, add volatile to some asm blobs in the nyan romstage code.
BUG=None
TEST=Booted on nyan rev1.
BRANCH=None
Original-Change-Id: I819e068e738e94ea749fcb72bba2eee080e1dfb1
Original-Signed-off-by: Gabe Black <gabeblack at google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/185610
Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
Original-Commit-Queue: Gabe Black <gabeblack at chromium.org>
Original-Tested-by: Gabe Black <gabeblack at chromium.org>
(cherry picked from commit 76c09581d6ca4dc6c2f9048f599822939f439d11)
Signed-off-by: Marc Jones <marc.jones at se-eng.com>
Change-Id: I0b32197abf0ddc5f454f9c2415a65d98c60ca48b
Reviewed-on: http://review.coreboot.org/7396
Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/7396 for details.
-gerrit
More information about the coreboot-gerrit
mailing list