[coreboot-gerrit] New patch to review for coreboot: 9437d08 northbridge/amd/agesa/family1{2, 4}: make get_node_pci() static
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Thu Nov 20 14:39:22 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7530
-gerrit
commit 9437d082a27446b0bbad12a2a8ba0d9b0098bfab
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Fri Nov 21 00:37:02 2014 +1100
northbridge/amd/agesa/family1{2,4}: make get_node_pci() static
Function is local only, as is with other families also.
Change-Id: I1f652be1763a319b2f1c9b0f53e76d6bc44f3450
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/northbridge/amd/agesa/family12/northbridge.c | 4 +---
src/northbridge/amd/agesa/family12/northbridge.h | 2 --
src/northbridge/amd/agesa/family14/northbridge.c | 2 +-
src/northbridge/amd/agesa/family14/northbridge.h | 2 --
4 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/northbridge/amd/agesa/family12/northbridge.c b/src/northbridge/amd/agesa/family12/northbridge.c
index 94de010..d1686e0 100644
--- a/src/northbridge/amd/agesa/family12/northbridge.c
+++ b/src/northbridge/amd/agesa/family12/northbridge.c
@@ -47,8 +47,7 @@ static device_t __f2_dev[FX_DEVS];
static device_t __f4_dev[FX_DEVS];
static unsigned fx_devs=0;
-
-device_t get_node_pci(u32 nodeid, u32 fn)
+static device_t get_node_pci(u32 nodeid, u32 fn)
{
if ((CONFIG_CDB + nodeid) < 32) {
return dev_find_slot(CONFIG_CBB, PCI_DEVFN(CONFIG_CDB + nodeid, fn));
@@ -57,7 +56,6 @@ device_t get_node_pci(u32 nodeid, u32 fn)
}
}
-
static void get_fx_devs(void)
{
int i;
diff --git a/src/northbridge/amd/agesa/family12/northbridge.h b/src/northbridge/amd/agesa/family12/northbridge.h
index 3545048..301044d 100644
--- a/src/northbridge/amd/agesa/family12/northbridge.h
+++ b/src/northbridge/amd/agesa/family12/northbridge.h
@@ -23,6 +23,4 @@
static struct device_operations pci_domain_ops;
static struct device_operations cpu_bus_ops;
-device_t get_node_pci(u32 nodeid, u32 fn);
-
#endif /* NORTHBRIDGE_AMD_AGESA_FAM12_H */
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c
index 8384c98..00294b2 100644
--- a/src/northbridge/amd/agesa/family14/northbridge.c
+++ b/src/northbridge/amd/agesa/family14/northbridge.c
@@ -50,7 +50,7 @@ static device_t __f2_dev[FX_DEVS];
static device_t __f4_dev[FX_DEVS];
static unsigned fx_devs = 0;
-device_t get_node_pci(u32 nodeid, u32 fn)
+static device_t get_node_pci(u32 nodeid, u32 fn)
{
if ((CONFIG_CDB + nodeid) < 32) {
return dev_find_slot(CONFIG_CBB, PCI_DEVFN(CONFIG_CDB + nodeid, fn));
diff --git a/src/northbridge/amd/agesa/family14/northbridge.h b/src/northbridge/amd/agesa/family14/northbridge.h
index c5ee7b2..0ed0060 100644
--- a/src/northbridge/amd/agesa/family14/northbridge.h
+++ b/src/northbridge/amd/agesa/family14/northbridge.h
@@ -23,6 +23,4 @@
static struct device_operations pci_domain_ops;
static struct device_operations cpu_bus_ops;
-device_t get_node_pci(u32 nodeid, u32 fn);
-
#endif /* NORTHBRIDGE_AMD_AGESA_FAM14_H */
More information about the coreboot-gerrit
mailing list