[coreboot-gerrit] New patch to review for coreboot: df53429 acpi: Don't add an empty SSDT.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sat Oct 11 04:13:58 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7043

-gerrit

commit df534296077b1112218768f2431717d3ef9b613b
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Fri Oct 10 20:40:41 2014 +0200

    acpi: Don't add an empty SSDT.
    
    It's harmless but useless.
    
    Change-Id: Iaaa5f6933d120a2071b2e32e62e36e63afa96be3
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/x86/boot/acpi.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/arch/x86/boot/acpi.c b/src/arch/x86/boot/acpi.c
index ea65666..b9fbc81 100644
--- a/src/arch/x86/boot/acpi.c
+++ b/src/arch/x86/boot/acpi.c
@@ -749,9 +749,11 @@ unsigned long write_acpi_tables(unsigned long start)
 	printk(BIOS_DEBUG, "ACPI:     * SSDT\n");
 	ssdt = (acpi_header_t *)current;
 	acpi_create_ssdt_generator(ssdt, ACPI_TABLE_CREATOR);
-	current += ssdt->length;
-	acpi_add_table(rsdp, ssdt);
-	ALIGN_CURRENT;
+	if (ssdt->length > sizeof(acpi_header_t)) {
+		current += ssdt->length;
+		acpi_add_table(rsdp, ssdt);
+		ALIGN_CURRENT;
+	}
 
 	printk(BIOS_DEBUG, "ACPI:    * MCFG\n");
 	mcfg = (acpi_mcfg_t *) current;



More information about the coreboot-gerrit mailing list