[coreboot-gerrit] New patch to review for coreboot: 17c71b9 util/board_status: Create `build` before copying to it
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Fri Oct 17 09:57:23 CEST 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7081
-gerrit
commit 17c71b926dfd26f56204d9dbcf96f6f4a4657658
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Fri Oct 17 09:49:14 2014 +0200
util/board_status: Create `build` before copying to it
Running `board_status.sh` fails when the directory `build/` does not exist.
$ LANG=C ls build
ls: cannot access build: No such file or directory
$ sudo util/board_status/board_status.sh
[…]
make: Entering directory '/src/coreboot/util/cbfstool'
make: Leaving directory '/src/coreboot/util/cbfstool'
cp: cannot create regular file 'build/cbfstool': No such file or directory
build/cbfstool not found
So ensure that the directory `build/` exists, before copying `cbfstool` to it.
Change-Id: I44155a0ca1eccc7b447b88ffaf6f3591b87fbad0
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
util/board_status/board_status.sh | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 49d2c73..c5cb071 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -215,9 +215,10 @@ tmpdir=$(mktemp -d --tmpdir coreboot_board_status.XXXXXXXX)
# Obtain board and revision info to form the directory structure:
# <vendor>/<board>/<revision>/<timestamp>
-cbfstool_cmd="build/cbfstool"
-if test ! -x build/cbfstool; then
- make -C util/cbfstool/ && cp util/cbfstool/cbfstool build/cbfstool
+cbfstool_cmd="util/cbfstool/cbfstool"
+if test ! -x cbfstool_cmd; then
+ mkdir -p build
+ make -C util/cbfstool/
fi
test_cmd $LOCAL "$cbfstool_cmd"
$cbfstool_cmd build/coreboot.rom extract -n config -f ${tmpdir}/config.txt
More information about the coreboot-gerrit
mailing list